MNT: Add explicit support for Python 3.10 on windows #3706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
changed the title
neutrinoceros
added
infrastructure
|
I don't yet understand why this the test isn't skipped on Jenkins, so I'll switch this to draft for now and remove it from the 4.0.2 milestone |
neutrinoceros
force-pushed
the
py310_support_win
branch
2 times, most recently
from
6a83d2e
to
56b32ea
Compare
|
Adding the backport label instead of the milestone to signal that it'd be cool to backport this on merge but it's not a blocker for the release |
neutrinoceros
force-pushed
the
py310_support_win
branch
from
67deb4f
to
43f6d75
Compare
|
Moving this to draft for now because it seems possible that a solution could be found quickly to avoid skipping the failing test. |
neutrinoceros
force-pushed
the
py310_support_win
branch
from
3a444d4
to
43f6d75
Compare
neutrinoceros
force-pushed
the
py310_support_win
branch
from
e77f4cc
to
4cfbb50
Compare
|
rebased on top of #3708 |
|
This is back in draft -- should it be marked ready? |
|
the only reason this is in draft mode is because it's based on #3708 |
|
Failures are unrelated. I'll mark it as ready for review when CI is stabilised |
neutrinoceros
force-pushed
the
py310_support_win
branch
2 times, most recently
from
33bdaa7
to
f750d88
Compare
…k on any test runner with any Python version
neutrinoceros
force-pushed
the
py310_support_win
branch
from
8850484
to
55bd8ee
Compare
neutrinoceros
force-pushed
the
py310_support_win
branch
from
c313120
to
55bd8ee
Compare
matthewturk
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Complements #3543.
I've been testing this on my fork and I believe it is now ready.
I was also able to remove the pinning added in #3298 since upstream issue was resolved.
As a temporary measure I'm conditionally skipping the one test that fails with cartopy 0.20 (reported as #3705) because I don't think it is bad enough to prevent us from testing on windows + Python 3.10, the issue is linked in the test code. I assume the regression is actually upstream and should be reported there.