[ZDF/3sat/phoenix.de] Extractor updates and fixes (#21185) #22191
Conversation
| @@ -39,10 +39,22 @@ def _extract_player(self, webpage, video_id, fatal=True): | |||
|
|
|||
|
|
|||
| class ZDFIE(ZDFBaseIE): | |||
| _VALID_URL = r'https?://www\.zdf\.de/(?:[^/]+/)*(?P<id>[^/?]+)\.html' | |||
| IE_NAME = "ZDF-3sat" | |||
There was a problem hiding this comment.
A bit confusing, since the filename is still zdf.py
There was a problem hiding this comment.
Should I rename the file?
| @@ -39,10 +39,22 @@ def _extract_player(self, webpage, video_id, fatal=True): | |||
|
|
|||
|
|
|||
| class ZDFIE(ZDFBaseIE): | |||
| _VALID_URL = r'https?://www\.zdf\.de/(?:[^/]+/)*(?P<id>[^/?]+)\.html' | |||
| IE_NAME = "ZDF-3sat" | |||
| _VALID_URL = r'https?://www\.(zdf|3sat)\.de/(?:[^/]+/)*(?P<id>[^/?]+)\.html' | |||
There was a problem hiding this comment.
I'll try to find a suitable test case. If anyone can supply one, I would be very happy!
There was a problem hiding this comment.
https://www.3sat.de/wissen/nano/190822-sendung-100.html for 3SAT
https://www.zdf.de/kinder/wickie-und-die-starken-maenner/der-wegezoll-102.html for ZDF
both running with the patch above
download klappt mit dem Patch
|
@dstftw: I cannot "fix" the downloader without a test case. |
wie kann ich helfen / how can I help ? |
If you know of any video on either site that doesn't work with the patch, feel free to post the link. I'm not certain such videos can be found by just browsing the website, since (probably) the whole tech stack was replaced. |
So far all downloads from ZDF and 3SAT work with the patch, and I download much of the above, since June I have manually inserted the patch into youtube-dl. I'm just waiting for the "3SATZDF done" to turn on the update function again. - Bis jetzt funktionieren alle Downloads von ZDF und 3SAT mit dem Patch, und ich lade viel von den Genannten herunter, seit Juni habe ich den Patch manuell eingefügt in youtube-dl. Ich warte nur noch auf das "3SATZDF erledigt" um dann die Update-Funktion wieder einzuschalten. |
|
I confirm that it works with (example) https://www.3sat.de/migration/3sat/robert-frank-don-t-blink-100.html . |
FliegendeWurst
changed the title
|
Phoenix is now in ARD Mediathek: https://www.ardmediathek.de/phoenix/ |
|
So, what is the problem with this pull request and that #21356. Why don't they get merged. Is there anything that need to be done? |
Yes wondering too... The issue seems to be more about decisions than actual implementation. |
|
@FliegendeWurst If I were you, I'd close this PR, rebase your changes and issue a new PR to get it integrated. Seeing the bandwidth on this repo I could understand why the maintainer might oversee updated PRs. Thanks for your work. |
|
@dstftw I rebased this PR, can you review it again? |
|
I can also confirm that the patch works. It would be very nice to add it to the master brunch. |
|
works like a charm. added it to my fork :) |
|
Yes works, would be great to see this finally merged @dstftw Thanks! |
|
Closing this PR since my repository is not available. I will open another PR. |
Thanks @FliegendeWurst !!! 👏 We really need to get this accepted for the/a next release! |
What is the purpose of your pull request?
3sat recently (?) changed their tech stack. It seems to work like ZDF's stack. In case you're wondering, they're both public TV channels in Germany. It's only logical that they would use the same tech.
Edit: turns out that phoenix.de still uses the older stack, so we have to
keep dreisat.py for nowmove that code to phoenix.py.Should the extractor file be renamed to zdf3sat.py or something like that?