-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3sat] New URL #21185
Comments
andrew@a68n:/mnt/nasd/VIDEO$ youtube-dl https://www.3sat.de/kultur/theater-und-tanz/tt-persona-100.html andrew@a68n:/mnt/nasd/VIDEO$ |
I have the same problem. Is there a solution for the new 3sat URL? |
A workaround on Chrome (should be similar on Firefox):
|
OK, did not try yet, but might also wirk with Firefox-Web-Inspector, you get the URL there from the network-tab upun starting to play something. |
I noticed this issue two days ago, and fixed it for myself within minutes: Actually, 3sat is now using the same technology as ZDF. The ZDF extractor successfully works for all the (few) URLs I have tried. The only, very minimal, change it requires, is an update to the URL scheme:
This will catch the new 3sat URLs without requiring a separate extractor, making youtube_dl/extractor/dreisat.py and the DreiSat extractor obsolete. (The ZDF extractor could be renamed to ZDF3Sat.) Everything seems the same as ZDF, like the vast amount of provided formats. The ZDF infrastructure even appears in the web pages' source. FTFY ;-) |
Hello @ALL:
That's all. |
Sorry, but the problem still exists in the newest version 2019-06-21: |
Yes, definitely. It's because, sadly, my pull-request is not yet merged into master and therefore not included in the newest version. |
No, if it is not merged. The branches do not exist in the original project. The only way would be to clone each of the forks containing the desired fixes and, then, to checkout the specific branch. Then you have a version per fix... |
Yeah, guys, I guess time will tell, interesting discussion. |
Worked fine for me as well! |
i understand how to clone but checking out and modifying doesn't make sense to me. i thought it was be as simple as changing some code, but that appears to not be the case in this situation |
It is quite that simple. Edit the code in your local copy, and run it with
as described in the developer instructions. This assumes you do not need to build a single executable, and have a python interpreter available. Otherwise, getting various changes into one youtube-dl:
|
I see. I was just trying to change the code and run the project in pycharm and got confused. I'll have to give this a try. Thanks! |
Kindergarten oder was? Muss ja schwer sein, das eben einzubauen... class ZDFIE(ZDFBaseIE):
|
This comment has been minimized.
This comment has been minimized.
@LinuxOpa: wenn's so einfach ist, warum machst du dann nicht einen PR? Die Maintainer sind mit reviews schon beschäftigt genug. [English translation: I opened a PR for you since you apparently didn't manage to do it yourself] |
Not working on https://www.3sat.de/migration/3sat/robert-frank-don-t-blink-100.html . |
The simple URL regex based solution works perfectly for this. Now, why has it not been merged? I need to check up on what has changed recently, but last I checked:
I can give another stab at a PR, as others have done, but don't know what to do about some of thise points. And why haven't I? Because my local fix works just fine! :-P |
I confirm that the url https://www.3sat.de/migration/3sat/robert-frank-don-t-blink-100.html does work with https://github.com/FliegendeWurst/youtube-dl branch 3sat-zdf-merger-bugfix-feature se #22191 . |
After checking up on existing PRs, I refine my opinion on this. Some of the linked PRs are just fine:
|
Current debian release buster features a fully workable version of mediathekview: andrew@a68n:~$ aptitude show mediathekview So most people would probably rather use this than youtube-dl, but of course it can still be interesting to visit websites of TV-channels directly using a web-browser in order to find contents of interest. |
Those who are interested in that can simple open https://mediathekviewweb.de in a browser on any kind of operating system and use this service there. But I guess this discussion is off-topic here. I consider it just as a workaround while youtube-dl is not working. |
sad to see this issue still open as of 20/02/2020 (what a date:) using youtube-dl 2020.01.24 |
Any updates on this? |
@larsschwegmann my fix (PR #22191) still works. |
works, but it is still not built into youtube-dl, so i use 2 versions, the always current one and a 'youtube-dl-3sat'. this is strange, why the build in is denied, can someone explain why? |
Hey, happy birthday, issue! :-) We're almost at the one year birthday. Still doesn't work. Sure, I can find the master.m3u8 manually in Chrome with the dev console, but that's besides the point, right? Please fix. Or maybe there could be an generic override, like "use ZDF extractor even though the URL is a different one". I don't know. Thanks! $ youtube-dl --version |
DISCLAIMER this is an ugly hack. But it works for me. Feel free to improve it :-) Ok, not sure if it helps anyone. But I made a hacky workaround for downloading 3sat stuff with youtube-dl. The URL to the master.m3u8 has a clear system: (and obviously sendung_wido; 300 might be some sort of bandwidth indicator, "1" might be the "position", but I'm ignoring that for now :-)) the upload Date is used for some template fields and can be found like this: $ grep uploadDate schatzkammer-regenwald-100.html Now, generating a master.m3u8 is quite easy (not tested very much, but works for my purposes): function get_3sat_master() {
} And ey presto, you can download it now: youtube-dl -o 'Schatzkammer Regenwald.mp4' $(get_3sat_master https://www.3sat.de/wissen/wissenschaftsdoku/schatzkammer-regenwald-100.html) Still hoping for a "proper" fix though. |
@annomatik my patch (#22191) still works. |
This is still bugging me (in every sense of the word) with every new install of YouTube-dl where I didn't manually fix this with @FliegendeWurst 's patch. Update 03. August 2020: still broken for 3sat, and kudos to @barsnick who mentioned this first. |
Current PR: #27068 |
* https://github.com/ytdl-org/youtube-dl: [9c9media] fix extraction for videos with multiple ContentPackages(closes ytdl-org#28309) [bbc] correct catched exception type [bbc] add support for BBC Reel videos(closes ytdl-org#21870, closes ytdl-org#23660, closes ytdl-org#28268) release 2021.03.02 [ChangeLog] Actualize [ci skip] [zdf] Rework extractors (closes ytdl-org#11606, closes ytdl-org#13473, closes ytdl-org#17354, closes ytdl-org#21185, closes ytdl-org#26711, closes ytdl-org#27068, closes ytdl-org#27930, closes ytdl-org#28198, closes ytdl-org#28199, closes ytdl-org#28274)
…closes ytdl-org#17354, closes ytdl-org#21185, closes ytdl-org#26711, closes ytdl-org#27068, closes ytdl-org#27930, closes ytdl-org#28198, closes ytdl-org#28199, closes ytdl-org#28274) * Generalize unique video ids for zdf based extractors * Improve extraction * Fix 3sat and phoenix
…closes ytdl-org#17354, closes ytdl-org#21185, closes ytdl-org#26711, closes ytdl-org#27068, closes ytdl-org#27930, closes ytdl-org#28198, closes ytdl-org#28199, closes ytdl-org#28274) * Generalize unique video ids for zdf based extractors * Improve extraction * Fix 3sat and phoenix
…closes ytdl-org#17354, closes ytdl-org#21185, closes ytdl-org#26711, closes ytdl-org#27068, closes ytdl-org#27930, closes ytdl-org#28198, closes ytdl-org#28199, closes ytdl-org#28274) * Generalize unique video ids for zdf based extractors * Improve extraction * Fix 3sat and phoenix
The text was updated successfully, but these errors were encountered: