[YSQL] Fix org.yb.pgsql.TestYsqlMetrics#testMetricRows #23956
Assignees
Labels
Comments
kai-franz
added
area/ysql
yugabyte-ci
added
kind/bug
kai-franz
added a commit
that referenced
this issue
Sep 17, 2024
Summary: D37636 adds table-level metrics to the `/statements` endpoint. This means that many metrics have the same name but a different `table_name` field. The parser in `Metrics.java` expects there to be only one metric with a given name, so if it sees the same name more than once, it overwrites the previous value for that metric. This revision modifies the metrics parser to skip over table-level metrics. Jira: DB-12855 Test Plan: ``` ./yb_build.sh --java-test 'org.yb.pgsql.TestYsqlMetrics#testMetricRows' ``` Reviewers: myang Reviewed By: myang Differential Revision: https://phorge.dev.yugabyte.com/D38103
jasonyb
pushed a commit
that referenced
this issue
Sep 19, 2024
Summary: 84f3fab [PLAT-15322] Make sure build files have fresh last_modified date to make sure Play Framework assets caching works as expected c7af74d [PLAT-15288] Use set_dbs endpoint when editing table selection for db scoped DR configs 8faeca6 [PLAT-15300] Update task progress poller logic e4f5943 [doc][ybm] VictoriaMetrics (#23819) 70aa7d7 [doc][ybm] Tablet peer alert (#23942) 2f70696 [doc] Smart driver clarification (#23933) 1525ced [docs] fix for a yb version not rendering (#23944) e9f3ec2 [#23843] YSQL: Fix flaky test testSchemaMismatchRetry in TestPgBatch 89b69cf [#23943]: YSQL: Fix Bitmap Scan crash in fastdebug GCC11 27446e2 [DOC-470] Include SSL Connectivity within the source database tabs. (#23878) def0fac [#23879] docdb: Improve rpc metrics test. 87a936a [PLAT-15353] Consistency checks testing hooks 0c41023 [#23956] YSQL: Fix org.yb.pgsql.TestYsqlMetrics#testMetricRows 388e045 [#21625,#21627] Docdb: Clear stale meta-cache entries at the end of clone Excluded: 5523770 [#23547] YSQL: fix pg_hint_plan crash with pg_hint_plan.enable_hint_table enabled 5951e18 [#23881] docdb: Update the hint to advisory_locks 10b5009 Minorfixes (#23986) 3d33b3e [PLAt-15133][PLAT-15332] Fix the preflight check for disk mount 9d8366b [PLAT-15345] Set 755 permissions on node-agent service file d298d44 [#22135] YSQL: Avoid read restart errors with ANALYZE 240e8f0 [PLAT-15355] Fix Node Addition Precheck logic to work correctly in case provider_id is missing 2a40433 [PLAT-15262]Add more checks for non-namespace scope supported universes f957dda [Docs] Minor fixes to docs pages around transactions (#23926) e4a8548 [PLAT-15326] Proper error handling in DDL atomicity check 10a629e [PLAT-13998][PLAT-15215]Support Image bundle creation and updation in provider requests 5f95ff9 [#23905] DocDB: Persistence for Master side Table/Object locks d4103e8 [#23513] YSQL: Fix broken org.yb.pgsql.TestYsqlMetrics#testExplainMaxMemory unit test Merge: - yb_pg_dbms_alert_session_A.out: - "advisory locks are not yet implemented": YB master 5951e18 changes the hint message for test queries added by YB pg15. Update the hint message. - yb_pg_dbms_alert_session_B.out: (same) - yb_pg_dbms_alert_session_C.out: (same) - yb_pg_dbms_pipe_session_A.out: (same) - yb_pg_dbms_pipe_session_B.out: (same) Test Plan: Jenkins: rebase: pg15-cherrypicks Reviewers: jason, tfoucher, qhu Reviewed By: qhu Subscribers: qhu Differential Revision: https://phorge.dev.yugabyte.com/D38163
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jira Link: DB-12855
Description
Java test
org.yb.pgsql.TestYsqlMetrics#testMetricRowsfailing after commit 9889df7Issue Type
kind/bug
Warning: Please confirm that this issue does not contain any sensitive information
The text was updated successfully, but these errors were encountered: