Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Manual fix for a yb-version not rendering correctly. #23944

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

aishwarya24
Copy link
Collaborator

No description provided.

@aishwarya24 aishwarya24 added the area/documentation Documentation needed label Sep 16, 2024
@aishwarya24 aishwarya24 self-assigned this Sep 16, 2024
Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for infallible-bardeen-164bc9 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 18ba09f
🔍 Latest deploy log https://app.netlify.com/sites/infallible-bardeen-164bc9/deploys/66e862c321524300084a8d28
😎 Deploy Preview https://deploy-preview-23944--infallible-bardeen-164bc9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@ddhodge ddhodge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why doesn't this work

@aishwarya24
Copy link
Collaborator Author

why doesn't this work

not sure, this looked like the only instance of being linked from includeMarkdown shortcode. Somehow this combination doesn’t work. Requires some debugging.

@aishwarya24 aishwarya24 merged commit 1525ced into yugabyte:master Sep 17, 2024
2 checks passed
@ddhodge
Copy link
Contributor

ddhodge commented Sep 17, 2024

cc @samiahmedsiddiqui

jasonyb pushed a commit that referenced this pull request Sep 19, 2024
Summary:
 84f3fab [PLAT-15322] Make sure build files have fresh last_modified date to make sure Play Framework assets caching works as expected
 c7af74d [PLAT-15288] Use set_dbs endpoint when editing table selection for db scoped DR configs
 8faeca6 [PLAT-15300] Update task progress poller logic
 e4f5943 [doc][ybm] VictoriaMetrics (#23819)
 70aa7d7 [doc][ybm] Tablet peer alert (#23942)
 2f70696 [doc] Smart driver clarification (#23933)
 1525ced [docs] fix for a yb version not rendering (#23944)
 e9f3ec2 [#23843] YSQL: Fix flaky test testSchemaMismatchRetry in TestPgBatch
 89b69cf [#23943]: YSQL: Fix Bitmap Scan crash in fastdebug GCC11
 27446e2 [DOC-470] Include SSL Connectivity within the source database tabs. (#23878)
 def0fac [#23879] docdb: Improve rpc metrics test.
 87a936a [PLAT-15353] Consistency checks testing hooks
 0c41023 [#23956] YSQL: Fix org.yb.pgsql.TestYsqlMetrics#testMetricRows
 388e045 [#21625,#21627] Docdb: Clear stale meta-cache entries at the end of clone
 Excluded: 5523770 [#23547] YSQL: fix pg_hint_plan crash with pg_hint_plan.enable_hint_table enabled
 5951e18 [#23881] docdb: Update the hint to advisory_locks
 10b5009 Minorfixes (#23986)
 3d33b3e [PLAt-15133][PLAT-15332] Fix the preflight check for disk mount
 9d8366b [PLAT-15345] Set  755 permissions on node-agent service file
 d298d44 [#22135] YSQL: Avoid read restart errors with ANALYZE
 240e8f0 [PLAT-15355] Fix Node Addition Precheck logic to work correctly in case provider_id is missing
 2a40433 [PLAT-15262]Add more checks for non-namespace scope supported universes
 f957dda [Docs] Minor fixes to docs pages around transactions (#23926)
 e4a8548 [PLAT-15326] Proper error handling in DDL atomicity check
 10a629e [PLAT-13998][PLAT-15215]Support Image bundle creation and updation in provider requests
 5f95ff9 [#23905] DocDB: Persistence for Master side Table/Object locks
 d4103e8 [#23513]  YSQL: Fix broken org.yb.pgsql.TestYsqlMetrics#testExplainMaxMemory unit test

Merge:
- yb_pg_dbms_alert_session_A.out:
  - "advisory locks are not yet implemented": YB master
    5951e18 changes the hint message
    for test queries added by YB pg15.  Update the hint message.
- yb_pg_dbms_alert_session_B.out: (same)
- yb_pg_dbms_alert_session_C.out: (same)
- yb_pg_dbms_pipe_session_A.out: (same)
- yb_pg_dbms_pipe_session_B.out: (same)

Test Plan: Jenkins: rebase: pg15-cherrypicks

Reviewers: jason, tfoucher, qhu

Reviewed By: qhu

Subscribers: qhu

Differential Revision: https://phorge.dev.yugabyte.com/D38163
@samiahmedsiddiqui
Copy link
Contributor

@ddhodge I think we should make it configurable otherwise we need to manually update this version every time when the new preview version release.

@ddhodge
Copy link
Contributor

ddhodge commented Sep 20, 2024

@ddhodge I think we should make it configurable otherwise we need to manually update this version every time when the new preview version release.

Yes - but how. It wasn't working, but don't know how to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation needed
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants