[loader] Fix group comboBase leaking into YUI modules

[juandopazo]

There is an issue in Loader when YUI is configured to use more than one comboBase. In some cases YUI modules like cookie may be loaded from the group's comboBase.

[yahoocla]

CLA is valid!

[juandopazo]

The Travis failure seems to be due to the lack of support for "^1.1.1" versions in Node 0.8.

@caridy can I get a +1?

[triptych]

Needs a HISTORY.md entry as well please.

[ericf]

LGTM

[caridy]

+1

[unkillbob]

This seems to have broken the case where you're not overriding the comboBase in a group.

This line:

comboBase    = group.comboBase;

overrides the comboBase with the group.comboBase even if the group.comboBase is undefined.

This is causing modules in combo loaded groups (that don't specify their own comboBase) in our environment to be requested with the URL:

<current page url>/undefined/<group root>/path/to/module.js

Changing the aforementioned line to the following resolves the issue for us:

comboBase    = group.comboBase || comboBase;

However I don't have time to put together a full pull request + tests etc right now.

[okuryu]

This PR has been cherry-picked into the master, and includes in v3.17.1.

• 00a283e
• 2a34279
• b306172