The group comboBase should inherit from the default if no group setting is specified #1837
Conversation
|
CLA is valid! |
|
Darn - that should have been dev-master not dev-3.x in the PR. |
|
@andrewnicols thanks! I guess we'll need 3.17.2. |
| @@ -1,10 +1,10 @@ | |||
| YUI Loader Change History | |||
| ========================= | |||
|
|
|||
| @VERSION@ | |||
| 3.17.2 | |||
There was a problem hiding this comment.
The release process handles replacing @VERSION@. You should leave it.
…ng is specified This fixes a regression caused by yui#1832.
|
D'oh! I managed to not change it on another commit I did today. Brain everyhwere. New commit awaits your approval. Thanks, Andrew |
|
Thanks for fixing this! I just noticed it after upgrading to 3.17.1. |
|
@andrewnicols I guess all of our brains where all over the place this week. |
|
I guess it's too late for that spelling fix - oops. |
|
@andrewnicols |
|
FYI I have verified the 3.17.2 RC in our environment and am happy that the issue is resolved for us :) |
|
This was merged into 3.17.2 |
This fixes the regression caused by #1832.
The other options (combine, comboSep, maxURLLength) are also affected in a similar way, but these are not a regression introduced in 3.17 so I'll submit those in a separate PR.