Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlatformCredentialsSet: configure spec.preserveUnknownFields=false #7284

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

AlexanderYastrebov
Copy link
Member

Explicitly set preserveUnknownFields: false to enable strict CRD validation and prohibit unknown fields in test environment first.

Conversion of CRD from v1beta1 to v1 (see #2991) resulted in preserveUnknownFields: true:

$ kubectl --context=example get crd platformcredentialssets.zalando.org -o yaml | grep preserveUnknownFields
  preserveUnknownFields: true
    message: 'spec.preserveUnknownFields: Invalid value: true: must be false'

and requires explicit false value to reset.

See also kubernetes-sigs/controller-tools#476 (comment)

Explicitly set `preserveUnknownFields: false` to enable strict
CRD validation and prohibit unknown fields in test environment first.

Conversion of CRD from v1beta1 to v1 (see #2991) resulted in
`preserveUnknownFields: true`:
```
$ kubectl --context=example get crd platformcredentialssets.zalando.org -o yaml | grep preserveUnknownFields
  preserveUnknownFields: true
    message: 'spec.preserveUnknownFields: Invalid value: true: must be false'
```
and requires explicit false value to reset.

See also kubernetes-sigs/controller-tools#476 (comment)

Signed-off-by: Alexander Yastrebov <[email protected]>
@AlexanderYastrebov AlexanderYastrebov added major Major feature changes or updates, e.g. feature rollout to a new country, new API calls. do-not-merge labels Apr 9, 2024
@mikkeloscar
Copy link
Contributor

👍

@AlexanderYastrebov
Copy link
Member Author

👍

@AlexanderYastrebov AlexanderYastrebov merged commit de32a97 into dev Apr 10, 2024
10 checks passed
@AlexanderYastrebov AlexanderYastrebov deleted the pcs/preserveUnknownFields-false branch April 10, 2024 08:55
This was referenced Apr 10, 2024
This was referenced Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Major feature changes or updates, e.g. feature rollout to a new country, new API calls. merged/alpha merged/beta merged/kube-1.28 merged/stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants