Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev to stable #7290

Merged
merged 3 commits into from
Apr 11, 2024
Merged

dev to stable #7290

merged 3 commits into from
Apr 11, 2024

Conversation

zalando-teapot-robot
Copy link
Contributor

  • PlatformCredentialsSet: configure spec.preserveUnknownFields=false (#⁠7284) - major Major feature changes or updates, e.g. feature rollout to a new country, new API calls.

AlexanderYastrebov and others added 3 commits April 9, 2024 18:32
@AlexanderYastrebov
PlatformCredentialsSet: configure spec.preserveUnknownFields=false
1376c9b 
Explicitly set `preserveUnknownFields: false` to enable strict
CRD validation and prohibit unknown fields in test environment first.

Conversion of CRD from v1beta1 to v1 (see #2991) resulted in
`preserveUnknownFields: true`:
```
$ kubectl --context=example get crd platformcredentialssets.zalando.org -o yaml | grep preserveUnknownFields
  preserveUnknownFields: true
    message: 'spec.preserveUnknownFields: Invalid value: true: must be false'
```
and requires explicit false value to reset.

See also kubernetes-sigs/controller-tools#476 (comment)

Signed-off-by: Alexander Yastrebov <[email protected]>
@AlexanderYastrebov
Merge pull request #7284 from zalando-incubator/pcs/preserveUnknownFi…
de32a97 
…elds-false

PlatformCredentialsSet: configure spec.preserveUnknownFields=false
@zalando-teapot-robot
Merge dev to dev-to-stable
499dc80
@zalando-teapot-robot zalando-teapot-robot added the major Major feature changes or updates, e.g. feature rollout to a new country, new API calls. label Apr 10, 2024
@szuecs szuecs added the frozen new updates to the dev branch won't be added to dev-to-alpha pull request label Apr 10, 2024
@mikkeloscar
Copy link
Contributor

👍

@szuecs
Copy link
Member

szuecs commented Apr 11, 2024

:

@szuecs
Copy link
Member

szuecs commented Apr 11, 2024

👍

@szuecs szuecs merged commit 5f8f5c1 into stable Apr 11, 2024
10 checks passed
@szuecs szuecs deleted the dev-to-stable branch April 11, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
frozen new updates to the dev branch won't be added to dev-to-alpha pull request internal/merges-tagged major Major feature changes or updates, e.g. feature rollout to a new country, new API calls.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zalando-teapot-robot @mikkeloscar @szuecs @AlexanderYastrebov