README: document spring properties together #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ePaul
added
the
spring-boot-2
|
👍 |
fbrns
reviewed
Jun 13, 2023
| * **lock-duration-buffer**: Since clocks never work exactly synchronous and sending events also takes some time, a safety | ||
| buffer is included. During the last x seconds before the expiration of the lock the events are not considered for | ||
| transmission. The default is currently 60 seconds but might change in future releases. | ||
| * **lock-duration** (seconds): The time the selected events are locked before transmission. If the transmission fails, |
There was a problem hiding this comment.
It's more the time the events are locked before re-transmission in case the previous attempt failed.
There was a problem hiding this comment.
Hmm, the events are locked before trying a transmission, and either they'll be sent out during that time (then they'll be deleted, so the time is irrelevant), the sending job doesn't get to the event (then the lock will expire and the next one will pick it up), or something goes wrong (then they stay locked until the lock expires, upon which again the next job run will pick it up).
Not sure how to easily condense this into sentence.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered by a recent question, I've added a table of all the configuration properties.
Also some other tweaks to related documentation.