replace SimpleSnapshotEventProducer by static of-methods #167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking through the README for #166, I noticed that for the compaction key, we use bean creation via
of
methods, while for the snapshot production we have a Simple... implementation.By now I think the
of
methods are a better style, so this PR introduces them, and deprecates the SimpleSnapshotEventProducer class.This PR should only be merged when we intend to release a new version soon (as otherwise the README doesn't fit).
I'm not sure this by itself warrants a new version, so we also can just leave it sitting here until we got another feature.