Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace SimpleSnapshotEventProducer by static of-methods #167

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

ePaul
Copy link
Member

@ePaul ePaul commented Jan 9, 2023

When looking through the README for #166, I noticed that for the compaction key, we use bean creation via of methods, while for the snapshot production we have a Simple... implementation.
By now I think the of methods are a better style, so this PR introduces them, and deprecates the SimpleSnapshotEventProducer class.

This PR should only be merged when we intend to release a new version soon (as otherwise the README doesn't fit).
I'm not sure this by itself warrants a new version, so we also can just leave it sitting here until we got another feature.

@ePaul ePaul added snapshots spring-boot-2 Issues/PRs which only apply to the Spring-Boot 2 versions (Releases 20.*+) labels Jan 9, 2023
@ePaul ePaul requested a review from fbrns as a code owner January 9, 2023 16:37
@ePaul
Copy link
Member Author

ePaul commented Jun 8, 2023

👍

1 similar comment
@fbrns
Copy link
Member

fbrns commented Jun 13, 2023

👍

@ePaul ePaul merged commit b3c48f9 into master Aug 22, 2023
@ePaul ePaul deleted the snapshotgenerator-non-simple branch August 22, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
snapshots spring-boot-2 Issues/PRs which only apply to the Spring-Boot 2 versions (Releases 20.*+)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants