Rewrite sharding as a codec #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbms
reviewed
Mar 24, 2023
jbms
reviewed
Mar 24, 2023
jbms
reviewed
Mar 24, 2023
|
@jstriebel Would you mind having a look at these changes? |
jstriebel
previously approved these changes
Apr 15, 2023
|
Thanks! Is there a tool to check the links? |
I think it's in the output of sphinx, but you might need to remove the cache to see all warnings. |
jstriebel
approved these changes
Apr 16, 2023
There was a problem hiding this comment.
LGTM! Should we merge this together with zarr-developers/zeps#34?
Yes, please! |
jbms
approved these changes
Apr 18, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the sharding specification from ZEP2 as a codec.