Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapts ZEP2 to codec #34

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

normanrz
Copy link
Contributor

Makes changes to the current ZEP2 draft to switch sharding from the storage transformer model to a codec.

Copy link
Member

@jstriebel jstriebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @jbms could you have a look as well?

draft/ZEP0002.md Outdated
}
```

#### `chunk_grid`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should presumably be changed back to just chunk_shape now

@jstriebel
Copy link
Member

@joshmoore @MSanKeys963 @rabernat Could one of you merge this PR? This also reflects the changes from zarr-developers/zarr-specs#223

@MSanKeys963
Copy link
Member

Thanks for sending the PR, @normanrz.
Merging this now.

@MSanKeys963 MSanKeys963 merged commit e63c013 into zarr-developers:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants