[TOPIC-GPIO] gpio: Update mcux igpio driver to use new gpio api #19247

MaureenHelm · 2019-09-18T13:23:58Z

Updates the mcux igpio driver and all associated boards to use new
device tree compatible gpio configuration flags. Implements new port
get/set/clear/toggle and pin_interrupt_configure functions recently
added to the gpio api.

Note that the driver now handles configuring by port inefficiently,
making separate register writes for each pin in the port. However, port
configuration is deprecated in the new gpio api and will soon be
removed.

Tested with:

samples/basic/blinky
samples/basic/button
tests/drivers/gpio/gpio_api_1pin

On boards:

mimxrt1015_evk
mimxrt1020_evk
mimxrt1050_evk
mimxrt1060_evk
mimxrt1064_evk

Signed-off-by: Maureen Helm [email protected]

agansari

Code is OKAY.
Tested on i.mx 1050 rt, works as expected.

pabigot · 2019-09-19T11:19:26Z

Has anybody run the 2-pin test #19249 on this? Hack it to specify usable pins and do pinmux if necessary.

MaureenHelm · 2019-09-27T18:54:22Z

Rebased to incorporate #19248. Still need to run the 2-pin test

drivers/gpio/gpio_mcux_igpio.c

mnkp · 2019-09-28T21:49:11Z

drivers/gpio/gpio_mcux_igpio.c

+	} else if (pin < 32) {
+		shift = 2 * (pin - 16);
+		base->ICR2 = (base->ICR2 & ~(3 << shift)) | (icr << shift);
+	} else {


There is an assert in the API that guarantees that pin number is smaller than the maximum port width. Since the maximum port width in case of mcux driver is 32 we could skip the else.

galak · 2019-10-02T03:43:35Z

Need to be rebased on updated topic-gpio branch.

MaureenHelm · 2019-10-04T02:34:38Z

Rebased to pick up 2-pin test, which now passes. The problem I had earlier was fixed by locking interrupts in mcux_igpio_pin_interrupt_configure

agansari · 2019-10-07T14:39:37Z

tests/drivers/gpio/gpio_basic_api/boards/mimxrt1050_evk.overlay

@@ -0,0 +1,13 @@
+/*
+ * Copyright (c) 2019 Nordic Semiconductor ASA


change copyright

I kept the Nordic copyright because I copied the file from another board

agansari · 2019-10-07T14:40:19Z

tests/drivers/gpio/gpio_basic_api/src/main.c

+#ifdef CONFIG_BOARD_MIMXRT1050_EVK
+	IOMUXC_SetPinMux(IOMUXC_GPIO_AD_B1_06_GPIO1_IO22, 0);
+	IOMUXC_SetPinMux(IOMUXC_GPIO_AD_B1_07_GPIO1_IO23, 0);
+
+	IOMUXC_SetPinConfig(IOMUXC_GPIO_AD_B1_06_GPIO1_IO22,
+			    IOMUXC_SW_PAD_CTL_PAD_PKE_MASK |
+			    IOMUXC_SW_PAD_CTL_PAD_HYS_MASK |
+			    IOMUXC_SW_PAD_CTL_PAD_SPEED(2) |
+			    IOMUXC_SW_PAD_CTL_PAD_DSE(6));
+
+	IOMUXC_SetPinConfig(IOMUXC_GPIO_AD_B1_07_GPIO1_IO23,
+			    IOMUXC_SW_PAD_CTL_PAD_PKE_MASK |
+			    IOMUXC_SW_PAD_CTL_PAD_SPEED(2) |
+			    IOMUXC_SW_PAD_CTL_PAD_DSE(6));
+#endif


i moved this to board's pinmux initialization

Yes this is ugly here, but I also don't want to make it the default pinmux configuration for the board. I think it's more likely these pins will be used for UART.

carlescufi · 2019-10-10T14:03:46Z

@MaureenHelm
The topic branch has been rebased. Could you please rebase this PR against it?

Updates the mcux igpio driver and all associated boards to use new device tree compatible gpio configuration flags. Implements new port get/set/clear/toggle and pin_interrupt_configure functions recently added to the gpio api. Assumes the gpio api layer handles translating logical flags to physical flags. Removes port configuration support since that feature is deprecated in the new gpio api. Tested with: - samples/basic/blinky - samples/basic/button - tests/drivers/gpio/gpio_api_1pin On boards: - mimxrt1015_evk - mimxrt1020_evk - mimxrt1050_evk - mimxrt1060_evk - mimxrt1064_evk Signed-off-by: Maureen Helm <[email protected]>

Fixes the user button label in the device tree to match the board's silkscreen. Signed-off-by: Maureen Helm <[email protected]>

Enables the 2-pin gpio test on the mimxrt1050_evk board by adding a dts overlay and configuring pinmuxes on the arduino header. Signed-off-by: Maureen Helm <[email protected]>

MaureenHelm · 2019-10-14T17:53:51Z

The topic branch has been rebased. Could you please rebase this PR against it?

Done

MaureenHelm added area: GPIO platform: NXP NXP labels Sep 18, 2019

MaureenHelm requested review from pabigot, galak, mnkp, dleach02 and agansari September 18, 2019 13:23

galak mentioned this pull request Sep 18, 2019

Convert GPIO drivers to new GPIO API #18530

Closed

zephyrbot added the area: Boards label Sep 18, 2019

galak changed the title ~~gpio: Update mcux igpio driver to use new gpio api~~ [TOPIC-GPIO] gpio: Update mcux igpio driver to use new gpio api Sep 18, 2019

agansari approved these changes Sep 19, 2019

View reviewed changes

galak force-pushed the topic-gpio branch from 5fc6ccb to 4bc09ff Compare September 19, 2019 20:29

MaureenHelm force-pushed the mcux-igpio branch from aa9956e to f6eb55b Compare September 19, 2019 20:45

MaureenHelm force-pushed the mcux-igpio branch from f6eb55b to f5fb3d4 Compare September 27, 2019 18:53

galak approved these changes Sep 27, 2019

View reviewed changes

mnkp reviewed Sep 28, 2019

View reviewed changes

galak force-pushed the topic-gpio branch from 470d655 to 683ab8f Compare October 2, 2019 03:39

MaureenHelm force-pushed the mcux-igpio branch from f5fb3d4 to 40a3037 Compare October 2, 2019 18:57

mnkp approved these changes Oct 3, 2019

View reviewed changes

MaureenHelm force-pushed the mcux-igpio branch from 40a3037 to 256e985 Compare October 4, 2019 02:32

zephyrbot added the area: Tests Issues related to a particular existing or missing test label Oct 4, 2019

andrewboie approved these changes Oct 5, 2019

View reviewed changes

pabigot approved these changes Oct 5, 2019

View reviewed changes

agansari suggested changes Oct 7, 2019

View reviewed changes

agansari mentioned this pull request Oct 10, 2019

[TOPIC-GPIO] gpio: Update mcux lpc driver to use new gpio api #19714

Merged

pabigot force-pushed the topic-gpio branch from 67daa80 to 2b556e1 Compare October 10, 2019 13:57

MaureenHelm added 3 commits October 14, 2019 12:24

boards: mimxrt1020_evk: Fix button label to match silkscreen

7b8e549

Fixes the user button label in the device tree to match the board's silkscreen. Signed-off-by: Maureen Helm <[email protected]>

tests: gpio: Enable gpio_basic_api test on mimxrt1050_evk

16396f7

Enables the 2-pin gpio test on the mimxrt1050_evk board by adding a dts overlay and configuring pinmuxes on the arduino header. Signed-off-by: Maureen Helm <[email protected]>

MaureenHelm force-pushed the mcux-igpio branch from 256e985 to 16396f7 Compare October 14, 2019 17:51

agansari approved these changes Oct 15, 2019

View reviewed changes

carlescufi merged commit be4e399 into zephyrproject-rtos:topic-gpio Oct 15, 2019

MaureenHelm deleted the mcux-igpio branch October 15, 2019 17:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TOPIC-GPIO] gpio: Update mcux igpio driver to use new gpio api #19247

[TOPIC-GPIO] gpio: Update mcux igpio driver to use new gpio api #19247

MaureenHelm commented Sep 18, 2019

agansari left a comment

pabigot commented Sep 19, 2019

MaureenHelm commented Sep 27, 2019

mnkp Sep 28, 2019

galak commented Oct 2, 2019

MaureenHelm commented Oct 4, 2019

agansari Oct 7, 2019

MaureenHelm Oct 14, 2019

agansari Oct 7, 2019

MaureenHelm Oct 14, 2019

carlescufi commented Oct 10, 2019

MaureenHelm commented Oct 14, 2019

		@@ -0,0 +1,13 @@
		/*
		* Copyright (c) 2019 Nordic Semiconductor ASA

[TOPIC-GPIO] gpio: Update mcux igpio driver to use new gpio api #19247

[TOPIC-GPIO] gpio: Update mcux igpio driver to use new gpio api #19247

Conversation

MaureenHelm commented Sep 18, 2019

agansari left a comment

Choose a reason for hiding this comment

pabigot commented Sep 19, 2019

MaureenHelm commented Sep 27, 2019

mnkp Sep 28, 2019

Choose a reason for hiding this comment

galak commented Oct 2, 2019

MaureenHelm commented Oct 4, 2019

agansari Oct 7, 2019

Choose a reason for hiding this comment

MaureenHelm Oct 14, 2019

Choose a reason for hiding this comment

agansari Oct 7, 2019

Choose a reason for hiding this comment

MaureenHelm Oct 14, 2019

Choose a reason for hiding this comment

carlescufi commented Oct 10, 2019

MaureenHelm commented Oct 14, 2019