Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attic-client: fix build against Nix 2.24 #159

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Conversation

Mic92
Copy link
Contributor

@Mic92 Mic92 commented Aug 17, 2024

The way I had to upgrade nix 2.24 is a bit hacky especially since it's not in nixos 24.05.

@philiptaron philiptaron mentioned this pull request Aug 17, 2024
13 tasks
Mic92 and others added 2 commits August 19, 2024 12:16
Perform version detection to keep supporting older versions
(and in the future, alternative implementations).

Co-authored-by: Jörg Thalheim <[email protected]>
@zhaofengli
Copy link
Owner

I added a version check so it remains compatible with older versions (and in the future, alternative implementations).

@zhaofengli zhaofengli merged commit acf3c35 into zhaofengli:main Aug 19, 2024
15 checks passed
@Mic92 Mic92 deleted the nix-2.24 branch August 21, 2024 04:54
@Mic92
Copy link
Contributor Author

Mic92 commented Aug 21, 2024

We have also backported nix 2.24 to stable btw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants