zig ld: handle -v linker arg #20512
Merged
zig ld: handle -v linker arg #20512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "-v" argument is the same as "--version", but the linker should not exit after the version is printed.
alexrp
reviewed
Jul 21, 2024
| @@ -2475,6 +2475,8 @@ fn buildOutputType( | |||
| fatal("unable to parse /version '{s}': {s}", .{ arg, @errorName(err) }); | |||
| }; | |||
| have_version = true; | |||
| } else if (mem.eql(u8, arg, "-v")) { | |||
| try std.io.getStdOut().writeAll("zig ld " ++ build_options.version ++ "\n"); | |||
| } else if (mem.eql(u8, arg, "--version")) { | |||
There was a problem hiding this comment.
While you're here, could you add a branch that handles -V as well, which just does warn("ignoring request for supported emulations: unimplemented", .{});? It should likewise not exit.
There was a problem hiding this comment.
While you're here, could you add a branch that handles
-Vas well, which just doeswarn("ignoring request for supported emulations: unimplemented", .{});? It should likewise not exit.
I'll have a look at this one in the meantime
alexrp
approved these changes
Jul 21, 2024
Verified this behavior with GNU |
The "-V' argument lists the supported emulations. While linker emulation is not implemented, it's beneficial to warn user regarding this.
alexrp
approved these changes
Jul 23, 2024
|
cc @kubkon (also needs approval to run CI) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "-v" argument is the same as "--version", but the linker should not exit after the version is printed.
CMake passes this argument during ABI info detection, and currently zig cc fails because this flag is not supported.
Fixes #20493