Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zig ld: handle -v linker arg #20512

Merged
merged 2 commits into from
Aug 7, 2024
Merged

zig ld: handle -v linker arg #20512

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a22ad7
zig ld: handle -v linker arg
aikawayataro Jul 6, 2024
73021c1
zig ld: handle -V linker arg
aikawayataro Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2475,6 +2475,8 @@ fn buildOutputType(
fatal("unable to parse /version '{s}': {s}", .{ arg, @errorName(err) });
};
have_version = true;
} else if (mem.eql(u8, arg, "-v")) {
try std.io.getStdOut().writeAll("zig ld " ++ build_options.version ++ "\n");
} else if (mem.eql(u8, arg, "--version")) {
Copy link
Member

@alexrp alexrp Jul 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here, could you add a branch that handles -V as well, which just does warn("ignoring request for supported emulations: unimplemented", .{});? It should likewise not exit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here, could you add a branch that handles -V as well, which just does warn("ignoring request for supported emulations: unimplemented", .{});? It should likewise not exit.

I'll have a look at this one in the meantime

try std.io.getStdOut().writeAll("zig ld " ++ build_options.version ++ "\n");
process.exit(0);
Expand Down