Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress: rework lptimer hal #12019

Merged

Conversation

shuopeng-deng
Copy link

Summary of changes

Fixed an issue when incorrect base time would be read when trying to set match values.
Changed set_match api to use an absolute ticks rather than delayed tick to match api name.
Added api set_delay to delay by a specific amount of ticks. Deprecated unused set_time api.
Simplified the logic for computing interrupts match value for cascading counters.

Impact of changes

Migration actions required

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

CY8CPROTO_062_4343W_GT_Test_Results.txt
CY8CPKIT_062_WIFI_BT_GT_Test_Results.txt


Reviewers

@ARMmbed/team-cypress


Changed set_match api to use an absolute ticks rather than delayed tick to match api name.
Added api set_delay to delay by a specific amount of ticks. Removed unused set_time api.
Simplified the logic for computing interrupts match value for cascading counters.
Fixed an issue when incorrect base time would be read when trying to set match values.
@ciarmcom ciarmcom requested review from maclobdell and a team December 3, 2019 18:00
@ciarmcom
Copy link
Member

ciarmcom commented Dec 3, 2019

@shuopeng-deng, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from a team December 5, 2019 08:20
@0xc0170 0xc0170 changed the title rework cypress lptimer hal Cypress: rework lptimer hal Dec 5, 2019
@yarbcy
Copy link
Contributor

yarbcy commented Dec 8, 2019

@please review.

@0xc0170 0xc0170 added needs: CI release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed needs: review labels Dec 11, 2019
@yarbcy
Copy link
Contributor

yarbcy commented Dec 13, 2019

@0xc0170 What is status of this PR ?

@adbridge
Copy link
Contributor

@yarbcy this is awaiting review from yourselves and @maclobdell

@yarbcy
Copy link
Contributor

yarbcy commented Dec 13, 2019

@yarbcy this is awaiting review from yourselves and @maclobdell

Done.

@kjbracey
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 17, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests

@mbed-ci
Copy link

mbed-ci commented Dec 17, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests

@mbed-ci
Copy link

mbed-ci commented Dec 17, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@adbridge
Copy link
Contributor

adbridge commented Apr 2, 2020

@Mergifyio backport mbed-os-5.15

@mergify
Copy link

mergify bot commented Apr 2, 2020

Command backport mbed-os-5.15: failure

No backport have been created

  • Backport to branch mbed-os-5.15 failed

1 similar comment
@mergify
Copy link

mergify bot commented Apr 2, 2020

Command backport mbed-os-5.15: failure

No backport have been created

  • Backport to branch mbed-os-5.15 failed

kyle-cypress pushed a commit to kyle-cypress/mbed-os that referenced this pull request Apr 2, 2020
Changed set_match api to use an absolute ticks rather than delayed tick to match api name.
Added api set_delay to delay by a specific amount of ticks. Removed unused set_time api.
Simplified the logic for computing interrupts match value for cascading counters.
Fixed an issue when incorrect base time would be read when trying to set match values.
artokin pushed a commit to artokin/mbed-os that referenced this pull request Apr 16, 2020
* upstream/mbed-os-5.15: (45 commits)
  Revert "Backport ARMmbed#12603: Add CYSBSYSKIT_01"
  Update STM32 EMAC driver based on review
  Update STM32 EMAC driver - limit RX frame length
  WHD: Remove an assert from get_rssi()
  crypto: Use updated ECC curve macros
  crypto: Update the service for Mbed Crypto 3.x
  crypto: Upgrade to Mbed Crypto 3.1.0
  tls: Upgrade to Mbed TLS 2.20.0
  Backport ARMmbed#12701: Custom BT Firmware for CYW9P62S1_43012EVB_01
  Backport ARMmbed#12603: Add CYSBSYSKIT_01
  Backport ARMmbed#12492: Update psoc6cm0p to version 1.1.1.
  Backport ARMmbed#12422: Cypress Asset Update
  Backport ARMmbed#12421: Cypress target reorganization
  Backport ARMmbed#12394: Fix Cypress 1M SDIO + other minor bugs
  Backport ARMmbed#12097: Cypress: Fix IAR Warnings
  Backport ARMmbed#12052: Fix for ARM issue 11859.
  Backport ARMmbed#12038: Remove qspi_frequency() call.
  Backport ARMmbed#12019: rework cypress lptimer hal
  Cellular: ALT1250 PPP cellular driver for mbed-os 5.15
  RZ_A1H and GR_LYCHEE: Enable bootloader support (Mbed OS 5.15)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants