Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cypress Targets Reorganization #12421

Merged
merged 5 commits into from
Feb 24, 2020
Merged

Cypress Targets Reorganization #12421

merged 5 commits into from
Feb 24, 2020

Conversation

dustin-crossman
Copy link
Contributor

Summary of changes

Removes unnecessary modular targets for 3 boards in favor of explicit targets (merges 6 folders into 3).
Removes now-unused post-build step for most cypress boards.

Impact of changes

Migration actions required

Documentation

None

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Tests for the three relevant targets are included:
CY8CKIT_062S2_43012-GCC_ARM.txt
CY8CPROTO_062_4343W-GCC_ARM.txt
CY8CPROTO_062S3_4343W-GCC_ARM.txt

Test failures:

  • All sleep failures are expected due to to a known incompatibility between the sleep tests and our UART driver.

Reviewers

@ciarmcom ciarmcom requested review from maclobdell and a team February 12, 2020 20:00
@ciarmcom
Copy link
Member

@dustin-crossman, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 reviewed Feb 13, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these renamed targets were non public, as I can see in the diff here. Therefore this is not breaking change, although using old names would lead now to an error. However, no release notes as they were not public before. Just checking

@dustin-crossman
Copy link
Contributor Author

@0xc0170 Yea no release notes necessary since they weren't public targets. Those CY8CMOD* names don't show up anywhere else anyway so no one should be using them.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 17, 2020

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Feb 17, 2020
@mbed-ci
Copy link

mbed-ci commented Feb 17, 2020

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR

@mergify mergify bot added needs: work and removed needs: CI labels Feb 17, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 18, 2020

CI restarted (we fixed the error)

@mbed-ci
Copy link

mbed-ci commented Feb 18, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@ifyall
Copy link

ifyall commented Feb 21, 2020

@maclobdell, can this be merged to master now and assigned a release?

Thank you in advance,

Ian

@0xc0170 0xc0170 merged commit 1629103 into ARMmbed:master Feb 24, 2020
@mergify mergify bot added the release version missing When PR does not contain release version, bot should label it and we fix it afterwards label Feb 24, 2020
@mergify
Copy link

mergify bot commented Feb 24, 2020

This PR does not contain release version label after merging.

@0xc0170 0xc0170 added release-version: 6.0.0-alpha-3 and removed release version missing When PR does not contain release version, bot should label it and we fix it afterwards labels Feb 24, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 24, 2020

Set to 6.0.0-beta-1

@adbridge
Copy link
Contributor

adbridge commented Apr 2, 2020

@Mergifyio backport mbed-os-5.15

@mergify
Copy link

mergify bot commented Apr 2, 2020

Command backport mbed-os-5.15: failure

No backport have been created

  • Backport to branch mbed-os-5.15 failed

kyle-cypress pushed a commit to kyle-cypress/mbed-os that referenced this pull request Apr 2, 2020
@dustin-crossman
Backport ARMmbed#12421: Cypress target reorganization
a15ed11 
- Remove CY8CMOD_062_4343W and merge into CY8CPROTO_062_4343W.
- Remove CY8CMOD_062S2_43012 and merge into CY8CKIT_062S2_43012.
- Remove CY8CMOD_062S3_4343W and merge into CY8CPROTO_062S3_4343W.
- Removed CY8CMODs from targets.json.
- Removed unnecessary PSOC6Code.complete post binary hook from cypress targets.
@kyle-cypress kyle-cypress mentioned this pull request Apr 2, 2020
Merged
artokin pushed a commit to artokin/mbed-os that referenced this pull request Apr 16, 2020
Merge remote-tracking branch 'upstream/mbed-os-5.15' into feature-wisun
190eb9a 
* upstream/mbed-os-5.15: (45 commits)
  Revert "Backport ARMmbed#12603: Add CYSBSYSKIT_01"
  Update STM32 EMAC driver based on review
  Update STM32 EMAC driver - limit RX frame length
  WHD: Remove an assert from get_rssi()
  crypto: Use updated ECC curve macros
  crypto: Update the service for Mbed Crypto 3.x
  crypto: Upgrade to Mbed Crypto 3.1.0
  tls: Upgrade to Mbed TLS 2.20.0
  Backport ARMmbed#12701: Custom BT Firmware for CYW9P62S1_43012EVB_01
  Backport ARMmbed#12603: Add CYSBSYSKIT_01
  Backport ARMmbed#12492: Update psoc6cm0p to version 1.1.1.
  Backport ARMmbed#12422: Cypress Asset Update
  Backport ARMmbed#12421: Cypress target reorganization
  Backport ARMmbed#12394: Fix Cypress 1M SDIO + other minor bugs
  Backport ARMmbed#12097: Cypress: Fix IAR Warnings
  Backport ARMmbed#12052: Fix for ARM issue 11859.
  Backport ARMmbed#12038: Remove qspi_frequency() call.
  Backport ARMmbed#12019: rework cypress lptimer hal
  Cellular: ALT1250 PPP cellular driver for mbed-os 5.15
  RZ_A1H and GR_LYCHEE: Enable bootloader support (Mbed OS 5.15)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@maclobdell maclobdell Awaiting requested review from maclobdell

Assignees
No one assigned
Labels
Backport Candidate devices: cypress release-version: 6.0.0-alpha-3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dustin-crossman @ciarmcom @0xc0170 @mbed-ci @ifyall @adbridge