Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cypress: Backport PRs from 6.0 to 5.15.2 #12753

Merged
merged 10 commits into from
Apr 7, 2020
Merged

Cypress: Backport PRs from 6.0 to 5.15.2 #12753

merged 10 commits into from
Apr 7, 2020

Conversation

kyle-cypress
Copy link

@kyle-cypress kyle-cypress commented Apr 2, 2020 •
edited
Loading

Summary of changes

Backport the following PRs for inclusion in 5.15.2:

#12019 - Cypress: rework lptimer hal
#12038 - Cypress: Remove qspi_frequency() call
#12052 - FPGA tests: Clear UART fix
#12097 - Cypress: Fix iar warnings
#12394 - Cypress: Fix SDIO communication issue on 1M boards and other minor fixes
#12421 - Cypress: Targets Reorganization
#12422 - Cypress: Asset Update
#12492 - Cypress: Update psoc6cm0p asset to version 1.1.1
#12603 - Cypress: Add CYSBSYSKIT_01
#12701 - Cypress: Custom BT Firmware for CYW9P62S1_43012EVB_01

Each PR is in its own commit. These are bundled together to reduce CI overhead (both mbed and Cypress internal).

All of have already been reviewed and merged.

Impact of changes

Fixes issues with intermittent SDIO related WiFi firmware load failures on CY8CKIT_062_WIFI_BT, CYW943012P6EVB_01, CYW9P62S1_43012EVB_01, CYW9P62S1_43438EVB_01. (#12394)

Migration actions required

NA

Documentation

NA

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

CY8CPROTO_062_4343W_GCC_ARM.txt
GT_FT_KIT_062_BLE_GCC.txt
GT_FT_KIT_062_WIFI_BT_GCC.txt
GT_FT_KIT_062S2_43012_GCC.txt
GT_FT_KIT_EVB_43012_GCC.txt
GT_FT_P6S1_43012EVB_01_GCC.txt
GT_FT_PROTO_062_4343W_GCC.txt
GT_FT_PROTO_062S3_4343W.txt
GT_FT_PROTO_063_BLE_GCC.txt

The failures of features-storage-tests-kvstore-direct_access_devicekey_test, features-storage-tests-kvstore-static_tests, and mbed-os-tests-mbedmicro-rtos-mbed-kernel_tick_count are transient. The tests passed when re-run manually.
The sleep/sleep manager failures are a known issue that we are working on fixing (#12434)
The other kvstore failures are not pre-existing from mbed-os-5.15.1. Many are already fixed on master; the rest are currently under investigation.
Network test results will be provided soon.

Reviewers

@ARMmbed/team-cypress

ShuopengDeng and others added 10 commits April 2, 2020 14:27
@ShuopengDeng
Backport ARMmbed#12019: rework cypress lptimer hal
880af5d 
Changed set_match api to use an absolute ticks rather than delayed tick to match api name.
Added api set_delay to delay by a specific amount of ticks. Removed unused set_time api.
Simplified the logic for computing interrupts match value for cascading counters.
Fixed an issue when incorrect base time would be read when trying to set match values.
@yarbcy
Backport ARMmbed#12038: Remove qspi_frequency() call.
63583ff 
cy_qspi_frequency is not implemented.
This change is made because for compatibility
reason with upcoming cy_hal changes.
@yarbcy
Backport ARMmbed#12052: Fix for ARM issue 11859.
738ec19 
1. Clear UART events before enabling
2. Reset device before return from test case
@ShuopengDeng
Backport ARMmbed#12097: Cypress: Fix IAR Warnings
a0ee701 
fix 'enumerated type mixed with another type' IAR warnings
fix 'statement is unreachable' IAR warning
@cypress-midd
Backport ARMmbed#12394: Fix Cypress 1M SDIO + other minor bugs
8199e25 
- Remove wounding for the hardware CRYPTO block. The PSoC 6 MPN CYW9P62S1_43012EVB_01 was revised
  to add the hardware crypto block.
- Add missing error checks for emac power up.
- Add a multiplied by 2 in the SDIO clock divider calculation to account for internal UDB divider.
  Note: Fixes issues with intermittent WiFi firmware load failures on CY8CKIT_062_WIFI_BT,
  CYW943012P6EVB_01, CYW9P62S1_43012EVB_01, CYW9P62S1_43438EVB_01.
@dustin-crossman
Backport ARMmbed#12421: Cypress target reorganization
a15ed11 
- Remove CY8CMOD_062_4343W and merge into CY8CPROTO_062_4343W.
- Remove CY8CMOD_062S2_43012 and merge into CY8CKIT_062S2_43012.
- Remove CY8CMOD_062S3_4343W and merge into CY8CPROTO_062S3_4343W.
- Removed CY8CMODs from targets.json.
- Removed unnecessary PSOC6Code.complete post binary hook from cypress targets.
@dustin-crossman
Backport ARMmbed#12422: Cypress Asset Update
ca47da6 
- Update psoc6pdl to version 1.4.1.2240
- Update psoc6 core_lib to version 1.1.1.11109.
- Update psoc6hal to 1.1.1.11145.
- Store RTC century and RTC state information in persistent BREG register.
@cypress-midd
Backport ARMmbed#12492: Update psoc6cm0p to version 1.1.1.
be4dd8e 
This version is built with PSoC 6 Peripheral Driver Library (PDL) 1.4.1
@dustin-crossman
Backport ARMmbed#12603: Add CYSBSYSKIT_01
4e6692b
@cy-opm
Backport ARMmbed#12701: Custom BT Firmware for CYW9P62S1_43012EVB_01
fa6bfb2
@ciarmcom
Copy link
Member

ciarmcom commented Apr 3, 2020

@kyle-cypress, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team April 3, 2020 01:00
@0xc0170 0xc0170 requested a review from adbridge April 3, 2020 07:10
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 3, 2020

All of these except for #12701 have already been reviewed and merged.

Merged now as well.

@adbridge
Copy link
Contributor

adbridge commented Apr 3, 2020 •
edited
Loading

@kyle-cypress thanks for this it looks like you corrupted the PR template, I will fix it for you. Also Could you please summarise each of the changes added to this PR rather than just quote the commits, this will help with the generation of the release note and also make it easier for those trying to work out what is in the release.

adbridge
adbridge approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT this seems to have all the right changes

@mergify mergify bot added needs: CI and removed needs: review labels Apr 3, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 3, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 3, 2020

Test run: FAILED

Summary: 1 of 9 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test-lts

@kyle-cypress
Copy link
Author

@kyle-cypress thanks for this it looks like you corrupted the PR template, I will fix it for you. Also Could you please summarise each of the changes added to this PR rather than just quote the commits, this will help with the generation of the release note and also make it easier for those trying to work out what is in the release.

I've updated the summary with the title for each of those PRs. Let me know if you need me to pull additional information in.

I've posted results from the base greentea suite. Everything looks okay there - there are a few failures, but nothing that wasn't pre-existing on 5.15.1 or that didn't go away when re-run.
I'm trying to get a network/netsocket greentea test pass but am running into some issues with our internal CI so I may not have those results until Monday.

@kyle-cypress
Copy link
Author

Test run: FAILED

Summary: 1 of 9 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

* jenkins-ci/mbed-os-ci_greentea-test-lts

The test failures are mostly network-related and in targets that this PR doesn't touch. Is there a CI issue?

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 5, 2020

The test failures are mostly network-related and in targets that this PR doesn't touch. Is there a CI issue?

yes, will need to investigate. cc @ARMmbed/mbed-os-test

@mbed-ci
Copy link

mbed-ci commented Apr 6, 2020

Test run: FAILED

Summary: 1 of 9 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test-lts

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 6, 2020

CI config still needs further fixing

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 6, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Apr 6, 2020

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test-lts

@mbed-ci
Copy link

mbed-ci commented Apr 7, 2020

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest-lts

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 7, 2020

Client restarted

@0xc0170 0xc0170 merged commit e1d7b5a into ARMmbed:mbed-os-5.15 Apr 7, 2020
@mergify mergify bot removed the ready for merge label Apr 7, 2020
@kyle-cypress kyle-cypress mentioned this pull request Apr 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@adbridge adbridge adbridge approved these changes

Assignees
No one assigned
Labels
release-version: 5.15.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@kyle-cypress @ciarmcom @0xc0170 @adbridge @mbed-ci @ShuopengDeng @yarbcy @cypress-midd @dustin-crossman @cy-opm