[Disco_F769NI] adding new target #2504

ohagendorf · 2016-08-20T22:05:23Z

new target DISCO_F769NI

adding target
adding to rtos libs
adding to travis build
exporters to GCC_ARM and Keil5 (uvision5) tested with MBED_BLINKY: OK

test results for GCC_ARM, ARM and IAR are all OK:
disco_f767ni.zip

ciarmcom · 2016-08-20T22:06:00Z

Can one of the admins verify this patch?

sandeepach · 2016-08-22T08:00:54Z

Hello Ohangendorf
Should the DIS_F769I not use hard FP for better results? Why is that we still use softfp here.
Especially since in my C code i am using CMSIS Instrinsics where ever possible, i see a high penalty with using the CMSIS Library with no FP. CMSIS does not compile with SOFTFP. It has only 3 options viz NO FP, SINGLE- precision FP and Double precision FP for M7.

Regards
Sandeep

adustm · 2016-08-22T08:30:18Z

hal/targets/hal/TARGET_STM/TARGET_STM32F7/TARGET_DISCO_F769NI/PinNames.h

+    D4          = PJ_0,
+    D5          = PC_8,
+    D6          = PF_7,
+    D7          = PI_3,


Hello, I don't have the board with me, but I can read from the schematics of the board that D7 is connected on PJ3, not PI3. Could you please check ?
Cheers

adustm · 2016-08-22T09:40:13Z

Hello @ohagendorf ,
I have reviewed the code as much as I could without the board.
You did an excellent work, thank you so much.
Some details should be changed in the peripheralpin.c, but the rest looks good.

Cheers
Armelle

sandeepach · 2016-08-25T09:19:05Z

May i please know if there is any progress on this?

0xc0170 · 2016-08-25T12:34:21Z

May i please know if there is any progress on this?

@ohagendorf Will you find time to address those comments?

ohagendorf · 2016-08-26T17:56:19Z

I just came back from an Internet free week. I'll do the corrections during the next days.

sandeepach · 2016-08-31T09:09:05Z

@ohagendorf Any updates on this?
Is there any plan to support Audio APIs with mbed for 769I and 746G Discovery boards? I know they are supported with Cube, but would be good to integrate them with mbed.

ohagendorf · 2016-08-31T17:43:49Z

I did the rework as suggested by @adustm .
Test results are the same as before but now additonal with MBED_A28 (CAN loopback test).
And I rebased it.

But there will be a conflict with PR #2571 : when this PR is merged earlier than there is some work necessary and vice versa ( @svastm )

disco_f769ni.zip

sandeepach · 2016-09-06T10:49:35Z

Any further updates on this? Is this good to merge?

ohagendorf · 2016-09-08T08:21:48Z

I added the missing ethernet initialisation.

And I run the following tests:

mbed test -m DISCO_F769NI -t GCC_ARM

and

mbed test -m DISCO_F769NI -t ARM

The tests mainly run through. But maybe network test have a timing, network or similar problem at my PC. I repeated the failed tests as single test runs. Sometimes I've got a timeout sometimes they run through.

disco_f769ni.zip

ohagendorf · 2016-09-08T11:01:09Z

When these tests run through does that mean that a "5" can be added to release_versions in targets.json?

bridadan · 2016-09-08T15:12:11Z

@ohagendorf Those test results look good to me. Do you have results for the ARM and IAR toolchain?

The two network tests that had issues are based on UDP, which sometimes does fail due to the nature of UDP. If you see that they pass when you run them again individually then they should be ok.

ohagendorf · 2016-09-08T15:20:22Z

ARM and GCC_ARM both are included in the zip file above.
IAR is missing. I'll submit the definitions and hand in the results here.
The failed network tests are OK when run them again manually.

ohagendorf · 2016-09-09T12:17:08Z

I submitted the IAR definitions for the project generator.

Unfortunately I have only a Keil license but no IAR. And several tests are bigger than 32k. I attached the results of possibles test:

disco_f769ni_iar.zip

The following tests couldn't be tested (>32k):

features-frameworks-utest-tests-unit_tests-control_type
features-net-feature_ipv4-tests-mbedmicro-net-nist_internet_time_service
features-net-feature_ipv4-tests-mbedmicro-net-tcp_client_echo
features-net-feature_ipv4-tests-mbedmicro-net-tcp_client_hello_world
features-net-feature_ipv4-tests-mbedmicro-net-udp_echo_client
tests-mbed_drivers-callback
tests-mbed_drivers-dev_null
tests-mbed_drivers-rtc
tests-mbed_drivers-stl_features

as suggested by adustm

the IPV4 feature was already enabled in an earlier commit but the mbed 5 ethernet initialisation was missing

ohagendorf · 2016-09-09T12:59:21Z

rebased - test results are the same

sg- · 2016-09-09T20:09:18Z

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

sg- · 2016-09-09T23:04:12Z

/morph test

mbed-bot · 2016-09-10T03:09:08Z

[Build 887]
FAILURE: Something went wrong when building and testing.

mbed-bot · 2016-09-10T06:16:29Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 807

All builds and test passed!

bugfixing the can loop test which failed after PR ARMmbed#2504

Release mbed-os-5.1.4 Changes: New Targets: 2504: [Disco_F769NI] adding new target [#2504] 2654: DELTA_DFBM_NQ620 platform porting [#2654] 2615: [MTM_MTCONNECT04S] Added support for MTM_MTCONNECT04S [#2615] 2548: Nucleof303ze [#2548] Fixes: 2678: Fixing NCS36510 compile on Linux #2678 2657: [MAX326xx] Removed echoing of characters and carriage return. #2657 2651: Use lp_timer to count time in the deepsleep tests #2651 2645: NUCLEO_F446ZE - Enable mbed5 release version #2645 2643: Fix thread self termination #2643 2634: Updated USBHost for library changes #2634 2633: Updated USBDevice to use Callback #2633 2630: Test names not dependent on disk location of root #2630 2624: CFSTORE Bugfix for realloc() moving KV area and cfstore_file_t data structures not being updated correctly #2624 2623: DISCO_L476VG - Add Serial Flow Control pins + add SERIAL_FC macro #2623 2617: STM32F2xx - Enable Serial Flow Control #2617 2613: Correctly providing directories to build_apis #2613 2607: Fix uvisor memory tracing #2607 2604: Tools - Fix fill section size variation #2604 2601: Adding ON Semiconductor copyright notice to source and header files. #2601 2597: [HAL] Fixed "intrinsic is deprecated" warnings #2597 2596: [HAL] Improve memory tracer #2596 2594: Fix TCPServer constructor #2594 2593: Add app config command line switch for test and make #2593 2589: [NUC472] Fix heap configuration error with armcc #2589 2588: Timing tests drift refactor #2588 2587: add PTEx pins as option for SPI on Hexiwear - for SD Card Interface #2587 2584: Set size of callback irq array to IrqCnt #2584 2583: github issue and PR templates #2583 2582: [GCC_CR] fix runtime hang for baremetal build #2582 2580: lwip - Add check for previously-bound socket #2580 2579: lwip - Fix handling of max sockets in socket_accept #2579 2578: Fix double free in NanostackInterface #2578 2576: Add smoke test that builds example programs with mbed-cli #2576 2575: tools-config! - Allow an empty or mal-formed config to be passed to the config system #2575 2562: Fix GCC lazy init race condition and add test #2562 2559: [utest]: Allow the linker to remove any part of utest if not used #2559 2545: Added define guards for SEQUENTIAL_FLASH_JOURNAL_MAX_LOGGED_BLOBS so #2545 2538: STM32F4xx - Add support of ADC internal channels (Temp, VRef, VBat) #2538 2521: [NUCLEO_F207ZG] Add MBED5 capability #2521 2514: Updated FlexCan and SAI SDK drivers #2514 2487: Runtime dynamic memory tracing #2487 2442: Malloc heap info #2442 2419: [STM32F1] Add asynchronous serial #2419 2393: [tools] Prevent trace-backs from incomplete args #2393 2245: Refactor export subsystem #2245 2130: stm32 : reduce number of device.h files #2130

bugfixing the can loop test which failed after PR #2504

Changes: New Targets: #2504: [Disco_F769NI] adding new target [ARMmbed/mbed-os#2504] #2654: DELTA_DFBM_NQ620 platform porting [ARMmbed/mbed-os#2654] #2615: [MTM_MTCONNECT04S] Added support for MTM_MTCONNECT04S [ARMmbed/mbed-os#2615] #2548: Nucleof303ze [ARMmbed/mbed-os#2548] Fixes: #2657: [MAX326xx] Removed echoing of characters and carriage return. [ARMmbed/mbed-os#2657] #2651: Use lp_timer to count time in the deepsleep tests [ARMmbed/mbed-os#2651] #2643: Fix thread self termination [ARMmbed/mbed-os#2643] #2623: DISCO_L476VG - Add Serial Flow Control pins + add SERIAL_FC macro [ARMmbed/mbed-os#2623] #2617: STM32F2xx - Enable Serial Flow Control [ARMmbed/mbed-os#2617] #2601: Adding ON Semiconductor copyright notice to source and header files. [ARMmbed/mbed-os#2601] #2597: [HAL] Fixed "intrinsic is deprecated" warnings [ARMmbed/mbed-os#2597] #2589: [NUC472] Fix heap configuration error with armcc [ARMmbed/mbed-os#2589] #2587: add PTEx pins as option for SPI on Hexiwear - for SD Card Interface [ARMmbed/mbed-os#2587] #2584: Set size of callback irq array to IrqCnt [ARMmbed/mbed-os#2584] #2582: [GCC_CR] fix runtime hang for baremetal build [ARMmbed/mbed-os#2582] #2562: Fix GCC lazy init race condition and add test [ARMmbed/mbed-os#2562] #2538: STM32F4xx - Add support of ADC internal channels (Temp, VRef, VBat) [ARMmbed/mbed-os#2538] #2514: Updated FlexCan and SAI SDK drivers [ARMmbed/mbed-os#2514] #2442: Malloc heap info [ARMmbed/mbed-os#2442] #2419: [STM32F1] Add asynchronous serial [ARMmbed/mbed-os#2419] #2130: stm32 : reduce number of device.h files [ARMmbed/mbed-os#2130] #2678: Fixing NCS36510 compile on Linux [ARMmbed/mbed-os#2678] #2607: Fix uvisor memory tracing [ARMmbed/mbed-os#2607] #2596: [HAL] Improve memory tracer [ARMmbed/mbed-os#2596] #2487: Runtime dynamic memory tracing [ARMmbed/mbed-os#2487]

ohagendorf mentioned this pull request Aug 20, 2016

Add Support For Discovery F769I #2182

Closed

adustm reviewed Aug 22, 2016
View reviewed changes

sg- added needs: work needs: CI labels Aug 23, 2016

ohagendorf force-pushed the disco_f769_ii branch from d79e635 to 53677de Compare August 31, 2016 16:46

ohagendorf added 2 commits September 9, 2016 14:18

[disco_f769ni] adding target

994cece

[disco_f769ni] adding rtos lib

54adfe1

ohagendorf added 5 commits September 9, 2016 14:18

[disco_f769ni] adding to build_travis

3598af0

[disco_f769ni] adding gcc_arm exporter definitions

95c5b78

disco_f769 some rework ...

05fc5f1

as suggested by adustm

disco_f769 some rework ... (part II)

d0e2f1e

as suggested by adustm

disco_f769ni adding ethernet init

765aeb0

the IPV4 feature was already enabled in an earlier commit but the mbed 5 ethernet initialisation was missing

ohagendorf force-pushed the disco_f769_ii branch from 2934ae4 to 765aeb0 Compare September 9, 2016 12:22

sg- removed the needs: work label Sep 9, 2016

sg- added ready for merge and removed needs: CI labels Sep 10, 2016

sg- merged commit c1ee7fb into ARMmbed:master Sep 10, 2016

sg- added release-version: 5.1.4 and removed ready for merge labels Sep 10, 2016

ohagendorf added a commit to ohagendorf/mbed-os that referenced this pull request Sep 13, 2016

classic mbed: bugfix can loop test

067ca86

bugfixing the can loop test which failed after PR ARMmbed#2504

ohagendorf mentioned this pull request Sep 13, 2016

classic mbed: bugfix can loop test #2682

Merged

adbridge pushed a commit that referenced this pull request Sep 28, 2016

classic mbed: bugfix can loop test

bf1b1ca

bugfixing the can loop test which failed after PR #2504

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Disco_F769NI] adding new target #2504

[Disco_F769NI] adding new target #2504

ohagendorf commented Aug 20, 2016

ciarmcom commented Aug 20, 2016

sandeepach commented Aug 22, 2016

adustm Aug 22, 2016

ohagendorf Aug 31, 2016

adustm commented Aug 22, 2016

sandeepach commented Aug 25, 2016

0xc0170 commented Aug 25, 2016

ohagendorf commented Aug 26, 2016

sandeepach commented Aug 31, 2016

ohagendorf commented Aug 31, 2016

sandeepach commented Sep 6, 2016

ohagendorf commented Sep 8, 2016

ohagendorf commented Sep 8, 2016

bridadan commented Sep 8, 2016

ohagendorf commented Sep 8, 2016

ohagendorf commented Sep 9, 2016 •

edited

Loading

ohagendorf commented Sep 9, 2016

sg- commented Sep 9, 2016

sg- commented Sep 9, 2016

mbed-bot commented Sep 10, 2016

mbed-bot commented Sep 10, 2016

[Disco_F769NI] adding new target #2504

[Disco_F769NI] adding new target #2504

Conversation

ohagendorf commented Aug 20, 2016

ciarmcom commented Aug 20, 2016

sandeepach commented Aug 22, 2016

adustm Aug 22, 2016

Choose a reason for hiding this comment

ohagendorf Aug 31, 2016

Choose a reason for hiding this comment

adustm commented Aug 22, 2016

sandeepach commented Aug 25, 2016

0xc0170 commented Aug 25, 2016

ohagendorf commented Aug 26, 2016

sandeepach commented Aug 31, 2016

ohagendorf commented Aug 31, 2016

sandeepach commented Sep 6, 2016

ohagendorf commented Sep 8, 2016

ohagendorf commented Sep 8, 2016

bridadan commented Sep 8, 2016

ohagendorf commented Sep 8, 2016

ohagendorf commented Sep 9, 2016 • edited Loading

ohagendorf commented Sep 9, 2016

sg- commented Sep 9, 2016

sg- commented Sep 9, 2016

mbed-bot commented Sep 10, 2016

mbed-bot commented Sep 10, 2016

Result: SUCCESS

Output

ohagendorf commented Sep 9, 2016 •

edited

Loading