Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NUC472] Fix heap configuration error with armcc #2589

Merged
merged 1 commit into from
Sep 10, 2016
Merged

[NUC472] Fix heap configuration error with armcc #2589

merged 1 commit into from
Sep 10, 2016

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Aug 31, 2016

No description provided.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 31, 2016

@ccli8 Can you add a better commit message? How does it fixes it?

I am missing also why is this magic required just for this target. I could not find any info in the commit message for previous changeset that added this #ifdef , neither in the code.

@ccli8
[NUC472] Fix heap configuration error with armcc
0194135 
In rtos/rtx/TARGET_CORTEX_M/RTX_CM_lib.h, Image$$ARM_LIB_HEAP$$Base/Image$$ARM_LIB_HEAP$$Length will cause zero memory allocation.
Fix it with Image$$ARM_LIB_HEAP$$ZI$$Base/Image$$ARM_LIB_HEAP$$ZI$$Length. This is to place heap at external SRAM.
@ccli8
Copy link
Contributor Author

ccli8 commented Aug 31, 2016

@0xc0170 I've added commit message. This #ifdef is to place heap at external SRAM for NUMAKER_PFM_NUC472 target.

@ccli8
Copy link
Contributor Author

ccli8 commented Sep 9, 2016

@0xc0170 How about progress?

@bogdanm
Copy link
Contributor

bogdanm commented Sep 9, 2016

I don't understand why we need this change only for this specific target? It seems a bit weird.

@sg- sg- mentioned this pull request Sep 9, 2016
Closed
@sg-
Copy link
Contributor

sg- commented Sep 9, 2016

This will fix #2658 for -t arm

@sg-
Copy link
Contributor

sg- commented Sep 9, 2016

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 824

All builds and test passed!

@sg- sg- merged commit 582da03 into ARMmbed:master Sep 10, 2016
@ccli8
Copy link
Contributor Author

ccli8 commented Sep 12, 2016

@sg This is to fix heap configuration error on armcc toolchain (-t ARM) and not to fix #2658. #2658 is another issue regarding lp_ticker.

@sg-
Copy link
Contributor

sg- commented Sep 12, 2016

This will fix #2658 for -t arm

Yep, there were 2 issues merged together there. The issue has been renamed to reflect the lp_ticker problem

theotherjimmy added a commit that referenced this pull request Sep 19, 2016
@theotherjimmy
Merge tag 'mbed-os-5.1.4' into new-exporters
6cc74c7 
Release mbed-os-5.1.4

Changes:

New Targets:
2504: [Disco_F769NI] adding new target [#2504]
2654: DELTA_DFBM_NQ620 platform porting [#2654]
2615: [MTM_MTCONNECT04S] Added support for MTM_MTCONNECT04S [#2615]
2548: Nucleof303ze [#2548]

Fixes:

2678: Fixing NCS36510 compile on Linux #2678
2657: [MAX326xx] Removed echoing of characters and carriage return. #2657
2651: Use lp_timer to count time in the deepsleep tests #2651
2645: NUCLEO_F446ZE - Enable mbed5 release version #2645
2643: Fix thread self termination #2643
2634: Updated USBHost for library changes #2634
2633: Updated USBDevice to use Callback #2633
2630: Test names not dependent on disk location of root #2630
2624: CFSTORE Bugfix for realloc() moving KV area and cfstore_file_t data structures not being updated correctly #2624
2623: DISCO_L476VG - Add Serial Flow Control pins + add SERIAL_FC macro #2623
2617: STM32F2xx - Enable Serial Flow Control #2617
2613: Correctly providing directories to build_apis #2613
2607: Fix uvisor memory tracing #2607
2604: Tools - Fix fill section size variation #2604
2601: Adding ON Semiconductor copyright notice to source and header files. #2601
2597: [HAL] Fixed "intrinsic is deprecated" warnings #2597
2596: [HAL] Improve memory tracer #2596
2594: Fix TCPServer constructor #2594
2593: Add app config command line switch for test and make #2593
2589: [NUC472] Fix heap configuration error with armcc #2589
2588: Timing tests drift refactor #2588
2587: add PTEx pins as option for SPI on Hexiwear - for SD Card Interface #2587
2584: Set size of callback irq array to IrqCnt #2584
2583: github issue and PR templates #2583
2582: [GCC_CR] fix runtime hang for baremetal build #2582
2580: lwip - Add check for previously-bound socket #2580
2579: lwip - Fix handling of max sockets in socket_accept #2579
2578: Fix double free in NanostackInterface #2578
2576: Add smoke test that builds example programs with mbed-cli #2576
2575: tools-config! -  Allow an empty or mal-formed config to be passed to the config system #2575
2562: Fix GCC lazy init race condition and add test #2562
2559: [utest]: Allow the linker to remove any part of utest if not used #2559
2545: Added define guards for SEQUENTIAL_FLASH_JOURNAL_MAX_LOGGED_BLOBS so  #2545
2538: STM32F4xx - Add support of ADC internal channels (Temp, VRef, VBat) #2538
2521: [NUCLEO_F207ZG] Add MBED5 capability #2521
2514: Updated FlexCan and SAI SDK drivers #2514
2487: Runtime dynamic memory tracing #2487
2442: Malloc heap info #2442
2419: [STM32F1] Add asynchronous serial #2419
2393: [tools] Prevent trace-backs from incomplete args #2393
2245: Refactor export subsystem #2245
2130: stm32 : reduce number of device.h files #2130
@ccli8 ccli8 deleted the ccli8 branch October 6, 2016 01:53
aisair pushed a commit to aisair/mbed that referenced this pull request Apr 30, 2024
@adbridge
Release 126 of the mbed library
e0772b4 
Changes:

New Targets:
#2504: [Disco_F769NI] adding new target [ARMmbed/mbed-os#2504]
#2654: DELTA_DFBM_NQ620 platform porting [ARMmbed/mbed-os#2654]
#2615: [MTM_MTCONNECT04S] Added support for MTM_MTCONNECT04S [ARMmbed/mbed-os#2615]
#2548: Nucleof303ze [ARMmbed/mbed-os#2548]

Fixes:

#2657: [MAX326xx] Removed echoing of characters and carriage return. [ARMmbed/mbed-os#2657]
#2651: Use lp_timer to count time in the deepsleep tests [ARMmbed/mbed-os#2651]
#2643: Fix thread self termination [ARMmbed/mbed-os#2643]
#2623: DISCO_L476VG - Add Serial Flow Control pins + add SERIAL_FC macro [ARMmbed/mbed-os#2623]
#2617: STM32F2xx - Enable Serial Flow Control [ARMmbed/mbed-os#2617]
#2601: Adding ON Semiconductor copyright notice to source and header files. [ARMmbed/mbed-os#2601]
#2597: [HAL] Fixed "intrinsic is deprecated" warnings [ARMmbed/mbed-os#2597]
#2589: [NUC472] Fix heap configuration error with armcc [ARMmbed/mbed-os#2589]
#2587: add PTEx pins as option for SPI on Hexiwear - for SD Card Interface [ARMmbed/mbed-os#2587]
#2584: Set size of callback irq array to IrqCnt [ARMmbed/mbed-os#2584]
#2582: [GCC_CR] fix runtime hang for baremetal build [ARMmbed/mbed-os#2582]
#2562: Fix GCC lazy init race condition and add test [ARMmbed/mbed-os#2562]
#2538: STM32F4xx - Add support of ADC internal channels (Temp, VRef, VBat) [ARMmbed/mbed-os#2538]
#2514: Updated FlexCan and SAI SDK drivers [ARMmbed/mbed-os#2514]
#2442: Malloc heap info [ARMmbed/mbed-os#2442]
#2419: [STM32F1] Add asynchronous serial [ARMmbed/mbed-os#2419]
#2130: stm32 : reduce number of device.h files [ARMmbed/mbed-os#2130]
#2678: Fixing NCS36510 compile on Linux [ARMmbed/mbed-os#2678]
#2607: Fix uvisor memory tracing [ARMmbed/mbed-os#2607]
#2596: [HAL] Improve memory tracer [ARMmbed/mbed-os#2596]
#2487: Runtime dynamic memory tracing [ARMmbed/mbed-os#2487]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release-version: 5.1.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ccli8 @0xc0170 @bogdanm @sg- @mbed-bot