Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAX32625 #3099

Merged
merged 5 commits into from
Nov 3, 2016
Merged

MAX32625 #3099

merged 5 commits into from
Nov 3, 2016

Conversation

jessexm
Copy link
Contributor

@jessexm jessexm commented Oct 20, 2016

Adding new Maxim Integrated platforms. Test results attached. Failures in legacy tests are due to hardware limitations.
max32625mbed_test_results_20161019.txt
max32625nexpaq_test_results_20161019.txt

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 24, 2016

max32625mbed_test_results_20161019.txt

Serial failures, that's the limitation. Can you share more?

@jeremybrodt
Copy link
Contributor

Our serial port does not support Tx or Rx only modes of communication, so neither of these tests can pass. The other test that fails, attempts to change the baudrate by deleting the serial object and instantiating a new one. Our UART has a hardware FIFO. Putchar will return as soon as the character is in the FIFO. It may not have been transmitted on the wire, yet. As I'm sure you are aware, the mbed hal API does not support desctructors to clean up or block in. The test prints a message and immediately deletes the object and instantiates a new one. This causes the FIFO to be cleared and reinitialized before the message is completely transmitted.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 25, 2016

Our serial port does not support Tx or Rx only modes of communication

This can't be handled by HAL? If serial object has RX only (TX=NC), then no sending, same would be for RX ?

The other test that fails, attempts to change the baudrate by deleting the serial object and instantiating a new one. Our UART has a hardware FIFO. Putchar will return as soon as the character is in the FIFO. It may not have been transmitted on the wire, yet. As I'm sure you are aware, the mbed hal API does not support desctructors to clean up or block in. The test prints a message and immediately deletes the object and instantiates a new one. This causes the FIFO to be cleared and reinitialized before the message is completely transmitted.

Can you create an issue to track this? We should improve tests, and having this covered what limitations our current tests have, will help us.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 25, 2016

@bridadan Do we have this devices in the CI?

@jeremybrodt
Copy link
Contributor

I have added the appropriate workarounds. All tests pass now.

@bridadan
Copy link
Contributor

@0xc0170 Test changes should be ok until we have a better solution for checking if the hardware FIFOs are free.

@bridadan
Copy link
Contributor

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

@mbed-bot
Copy link

[Build 1062]
FAILURE: Something went wrong when building and testing.

@bridadan
Copy link
Contributor

mbed 2 tests look OK

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 943

All builds and test passed!

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 28, 2016

I have added the appropriate workarounds. All tests pass now.

Thanks !

@jessexm @jeremybrodt Please rebase, there's a conflict

@sg-
Copy link
Contributor

sg- commented Nov 1, 2016

@jessexm can you resolve the conflict?

@jeremybrodt
Copy link
Contributor

@sg I have rebased and pushed, but the Cam-CI is now failing. What is the failure?

@bridadan
Copy link
Contributor

bridadan commented Nov 1, 2016

retest uvisor

@sg-
Copy link
Contributor

sg- commented Nov 1, 2016

/morph test

@sg-
Copy link
Contributor

sg- commented Nov 1, 2016

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

@mbed-bot
Copy link

mbed-bot commented Nov 1, 2016

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 983

All builds and test passed!

@mbed-bot
Copy link

mbed-bot commented Nov 1, 2016

[Build 1081]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

@sg-
Copy link
Contributor

sg- commented Nov 1, 2016

@0xc0170 review?

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 2, 2016 •
edited
Loading

@jeremybrodt
Nit: You can remove progen for targets definitions, "progen": {"target": "max32625mbed"} as it's not used anymore for exporting in this codebase.

LGTM

@sg- sg- merged commit 6712ed1 into ARMmbed:master Nov 3, 2016
@jeremybrodt jeremybrodt deleted the max32625 branch November 3, 2016 14:21
oter pushed a commit to oter/mbed-os that referenced this pull request Nov 21, 2016
Merge tag 'mbed-os-5.2.2' into fix_5.2
537d70d 
Release mbed OS 5.2.2 and mbed lib v129

Known issues in this release

There is currently a DNS resolution failure in Thread mode with this release. This causes a failure in the
mbed-os-example-client. This will be fixed in a subsequent release. This can be worked around by reverting
to mbed-os-5.2.0

Ports for Upcoming Targets

3011: Add u-blox Sara-N target. ARMmbed#3011
3099: MAX32625 ARMmbed#3099
3151: Add support for FRDM-K82F ARMmbed#3151
3177: New mcu k22512 fixing pr 3136 ARMmbed#3177

Fixes and Changes

2990: [tools] Parallel building of tests ARMmbed#2990
3008: NUCLEO_F072RB: Fix wrong timer channel number on pwm PB_5 pin ARMmbed#3008
3013: STM32xx - Change how the ADC internal pins are checked before pinmap_ ARMmbed#3013
3023: digital_loop tests update for STM32 ARMmbed#3023
3041: [nRF5] - added implementation of API of serial port flow control configuration. ARMmbed#3041
3092: [tools + tests] Adding parallelized build option for iar and uvision exporters ARMmbed#3092
3084: [nrf5] fix in Digital I/O : a gpioe pin was uninitialized badly ARMmbed#3084
3009: TRNG enabled. TRNG APIs implemented. REV A/B/C/D flags removed. Warnings removed ARMmbed#3009
3139: Handle [NOT_SUPPORTED] exception in make.py ARMmbed#3139
3074: Target stm init gcc alignement ARMmbed#3074
3140: [tests] Replacing getchar with RawSerial getc in greentea-client ARMmbed#3140
3158: Added support for 6lowpan PAN ID filter to mbed mesh api configuration ARMmbed#3158
2988: Update of can_api.c fixing ARMmbed#2987 ARMmbed#2988
3175: Updating IAR definition for the NCS36510 for IAR EW v7.8 ARMmbed#3175
3170: [tests] Preventing test from printing before Greentea __sync ARMmbed#3170
3169: [Update of ARMmbed#3014] Usb updates ARMmbed#3169
3143: CFStore fix needed for the Cloud Client ARMmbed#3143
3135: lwip - Fix memory leak in k64f cyclic-buffer overflow ARMmbed#3135
3048: Make update.py test compile examples prior to updating mbed-os version. ARMmbed#3048
3162: lwip/nsapi - Clean up warnings in network code ARMmbed#3162
3161: nsapi - Add better heuristic for the default record of DNS queries ARMmbed#3161
3173: [Exporters] Add a device_name to microbit entry in targets.json ARMmbed#3173
3072: i2c_loop tests update for STM32 ARMmbed#3072
2958: Allowing mbed_app.json files to be discovered for tests. ARMmbed#2958
2969: [nRF52] - switch irq priorities of driver handlers to the lowest level ARMmbed#2969
3078: lwip: Allow several configuration macros to be set externally (bis) ARMmbed#3078
3165: Add address type checks to NanostackInterface ARMmbed#3165
3166: nsapi_dns: Provide 2 IPv6-hosted default servers ARMmbed#3166
3171: [tools] Fixing project.py -S printing problem ARMmbed#3171
3172: [Exporters] New export-build tests ARMmbed#3172
3184: ARMmbed#3183 Compiler warning in trng_api.c with K64F  ARMmbed#3184
3185: Update tests to fix build failures. Also make the code similar to oth ARMmbed#3185
3104: [NuMaker] Support CAN and fix PWM CLK error ARMmbed#3104
3182: Exporter documentation ARMmbed#3182
3186: MultiTech mDot - add back SPI3 pins ARMmbed#3186
3187: [Export-Make] Use internal class variable for resolving templates in makefiles ARMmbed#3187
3195: [Exporters - Make-based] Quote the shell call in mkdir and rmdir ARMmbed#3195
3204: [Export build-test] Directory traversal error ARMmbed#3204
3189: [Exporters - Make-based] Force make exporter to search PATH for compilers ARMmbed#3189
3200: Using Popen for uVision and unifying the structure of the build function ARMmbed#3200
3075: nsapi - Add standardized return types for size and errors ARMmbed#3075
3221: u-blox odin w2 drivers update ARMmbed#3221
aisair pushed a commit to aisair/mbed that referenced this pull request Apr 30, 2024
Release 129 of the mbed library
b83b300 
Ports for Upcoming Targets

3011: Add u-blox Sara-N target. ARMmbed/mbed-os#3011
3099: MAX32625 ARMmbed/mbed-os#3099
3151: Add support for FRDM-K82F ARMmbed/mbed-os#3151
3177: New mcu k22512 fixing pr 3136 ARMmbed/mbed-os#3177

Fixes and Changes

3008: NUCLEO_F072RB: Fix wrong timer channel number on pwm PB_5 pin ARMmbed/mbed-os#3008
3013: STM32xx - Change how the ADC internal pins are checked before pinmap_ ARMmbed/mbed-os#3013
3041: [nRF5] - added implementation of API of serial port flow control configuration. ARMmbed/mbed-os#3041
3084: [nrf5] fix in Digital I/O : a gpioe pin was uninitialized badly ARMmbed/mbed-os#3084
3009: TRNG enabled. TRNG APIs implemented. REV A/B/C/D flags removed. Warnings removed ARMmbed/mbed-os#3009
3074: Target stm init gcc alignement ARMmbed/mbed-os#3074
2988: Update of can_api.c fixing #2987 ARMmbed/mbed-os#2988
3173: [Exporters] Add a device_name to microbit entry in targets.json ARMmbed/mbed-os#3173
2969: [nRF52] - switch irq priorities of driver handlers to the lowest level ARMmbed/mbed-os#2969
3184: #3183 Compiler warning in trng_api.c with K64F  ARMmbed/mbed-os#3184
3104: [NuMaker] Support CAN and fix PWM CLK error ARMmbed/mbed-os#3104
3186: MultiTech mDot - add back SPI3 pins ARMmbed/mbed-os#3186
3075: nsapi - Add standardized return types for size and errors ARMmbed/mbed-os#3075
3221: u-blox odin w2 drivers update ARMmbed/mbed-os#3221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.2.2 scope: new-target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jessexm @0xc0170 @jeremybrodt @bridadan @mbed-bot @sg- @adbridge