fast worward #1
Merged
fast worward #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are logging warnings if we are not able to parse the log files due to invalid or incorrect entries. However, we are adding those null values to "entries" list, which in turn causing NullReferenceException from Microsoft.Azure.WebJobs.Host.Blobs.Listeners.GetPathsForValidBlobWrites method at line no 88. I have encountered one issue where same storage has been used by multiple resources and there were invalid entries within log file. When Azure Function (Blob triggered) tried to parse those logs it started throwing : "An unhandled exception has occurred. Host is shutting down." and host was getting restarted. This situation should not throw unhandled exception. Please see the below exception. System.NullReferenceException : Object reference not set to an instance of an object. at Microsoft.Azure.WebJobs.Host.Blobs.Listeners.BlobLogListener.<>c.<GetPathsForValidBlobWrites>b__12_0(StorageAnalyticsLogEntry entry) at C:\projects\azure-webjobs-sdk-rqm4t\src\Microsoft.Azure.WebJobs.Extensions.Storage\Blobs\Listeners\BlobLogListener.cs : 88 at System.Linq.Enumerable.WhereSelectListIterator`2.MoveNext() at System.Linq.Enumerable.WhereEnumerableIterator`1.MoveNext() at async Microsoft.Azure.WebJobs.Host.Blobs.Listeners.BlobLogListener.GetRecentBlobWritesAsync(CancellationToken cancellationToken,Int32 hoursWindow) at C:\projects\azure-webjobs-sdk-rqm4t\src\Microsoft.Azure.WebJobs.Extensions.Storage\Blobs\Listeners\BlobLogListener.cs : 75 at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at async Microsoft.Azure.WebJobs.Host.Blobs.Listeners.PollLogsStrategy.ExecuteAsync(CancellationToken cancellationToken) at C:\projects\azure-webjobs-sdk-rqm4t\src\Microsoft.Azure.WebJobs.Extensions.Storage\Blobs\Listeners\PollLogsStrategy.cs : 115 at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at async Microsoft.Azure.WebJobs.Host.Blobs.Listeners.ScanBlobScanLogHybridPollingStrategy.ExecuteAsync(CancellationToken cancellationToken) at C:\projects\azure-webjobs-sdk-rqm4t\src\Microsoft.Azure.WebJobs.Extensions.Storage\Blobs\Listeners\ScanBlobScanLogHybridPollingStrategy.cs : 128 at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at async Microsoft.Azure.WebJobs.Host.Timers.TaskSeriesTimer.RunAsync(CancellationToken cancellationToken) at C:\projects\azure-webjobs-sdk-rqm4t\src\Microsoft.Azure.WebJobs.Host\Timers\TaskSeriesTimer.cs : 147
Reducing the number of async transitions in the core execution pipeline
ApplicationInsights performance improvements
* Rename log param to blobName
Fix name collision in indexer cache (#2645)
Fixing SDK version to 3.0.27
* add BinaryData default bindings. * poke CI? * fix build. * fix build.
Fixing null ref in AI logger
This change fixes #2349 by adding a description for the Microsoft.Azure.WebJobs.Extensions.Storage library. By default, SDK-style nuget projects will use the default value of "Package description", which is not very helpful. The description was written to be similar to the format used by other WebJobs packages.
…ication Insights. Resolves #2635
* Replace Flush() method with FlushAsync() * Revert WebJobs.Logging.ApplicationInsights.csproj * Add DiagnosticListener to log flushing exceptions * Update comment * Remove unnecessary using statement * Add default timeout of 5 seconds * Modify diagnostic listener name and add WebJobs diagnostic prefix * Upgrade Moq framework used and add unit tests * Add ApplicationInsightsDiagnosticConstants type to public surface area and increase delay in unit test * Add ApplicationInsightsDiagnosticConstants to other unit tests * Add timeout to CancellationToken * Update comment and adjust unit tests * Update comments and flushing message * Dispose DiagnosticListener
…when there is an exception (#2962)
Performance Improvements - AI Logging pipeline
…hts logging options (#3001)
Co-authored-by: Andy Staples <[email protected]>
…ot decommissioning (#2997) * Add prIssueManagement.yml to onboard repo to GitOps.ResourceManagement as FabricBot replacement Owners of the FabricBot configuration should have received email notification. The same information contained in the email is published internally at: https://aka.ms/gim/fabricbot. Details on the replacement service and the syntax of the new yaml configuration file is available publicly at: https://microsoft.github.io/GitOps/policies/resource-management.html Please review and merge this PR to complete the process of onboarding to the new service. * Deleting fabricbot.json --------- Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
* Add structured logging support to custom log states. * Make sure formatters don't capture locals. * Update LoggerExtensions.cs We ignore these `Aggregate`, `Result` and `Metric` logs and don't log it anywhere. We rely on the formatted message to ignore these logs (one example here https://github.com/Azure/azure-functions-host/blob/b42df4d4e63ab87f7a737f5a65dadf3eb7ba7de4/src/WebJobs.Script/Diagnostics/FileLogger.cs#L50). Setting the formatter to `null` so that we still ignore these. --------- Co-authored-by: Rohit Ranjan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.