refactor: Move contract stuff from types into circuits.js #9151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Oct 10, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
sklppy88
changed the title
sklppy88
force-pushed
the
ek/feat/new-address-implementation/move-contract-stuff-to-circuits-js
branch
from
607a4b3
to
646fa53
Compare
sklppy88
force-pushed
the
ek/feat/new-address-implementation/move-public-keys-struct
branch
from
a268885
to
21d8ffb
Compare
sklppy88
force-pushed
the
ek/feat/new-address-implementation/move-contract-stuff-to-circuits-js
branch
from
646fa53
to
f5303e3
Compare
sklppy88
force-pushed
the
ek/feat/new-address-implementation/move-contract-stuff-to-circuits-js
branch
3 times, most recently
from
322d621
to
c5375c6
Compare
sklppy88
force-pushed
the
ek/feat/new-address-implementation/move-public-keys-struct
branch
from
21d8ffb
to
62e4786
Compare
sklppy88
force-pushed
the
ek/feat/new-address-implementation/move-contract-stuff-to-circuits-js
branch
from
c5375c6
to
1e5a92b
Compare
sklppy88
changed the title
Thunkar
approved these changes
Oct 11, 2024
sklppy88
force-pushed
the
ek/feat/new-address-implementation/move-public-keys-struct
branch
from
62e4786
to
fdbc635
Compare
sklppy88
force-pushed
the
ek/feat/new-address-implementation/move-contract-stuff-to-circuits-js
branch
from
1e5a92b
to
7320bdb
Compare
Base automatically changed from
ek/feat/new-address-implementation/move-public-keys-struct
to
master
October 11, 2024 17:26
sklppy88
force-pushed
the
ek/feat/new-address-implementation/move-contract-stuff-to-circuits-js
branch
from
7320bdb
to
b1d4492
Compare
sklppy88
deleted the
ek/feat/new-address-implementation/move-contract-stuff-to-circuits-js
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need access to PublicKeys from types, and there was no obvious / trivial fix to this besides moving all the contract related stuff to circuits.js. I also refactored the said contract stuff when merging them.