Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fix encoding of public keys #9158

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: fix encoding of public keys #9158

wants to merge 1 commit into from

Conversation

sklppy88
Copy link
Contributor

Please read contributing guidelines and remove this line.

This was referenced Oct 10, 2024
Merged
Merged
@sklppy88 Graphite App
Copy link
Contributor Author

sklppy88 commented Oct 10, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sklppy88 and the rest of your teammates on Graphite Graphite

@sklppy88 sklppy88 mentioned this pull request Oct 10, 2024
Open
@sklppy88 Graphite App
Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sklppy88 and the rest of your teammates on Graphite Graphite

@sklppy88 sklppy88 changed the title init feat: fix encoding of public keys Oct 10, 2024
@sklppy88 sklppy88 marked this pull request as ready for review October 10, 2024 15:43
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-contract-instance-to-include-public-keys branch from b70bf57 to 3f96099 Compare October 11, 2024 09:00
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-encoder-to-allow-for-arbitrary-types branch from 68c8fe3 to 59415e7 Compare October 11, 2024 09:00
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-contract-instance-to-include-public-keys branch from 3f96099 to b990dcb Compare October 11, 2024 09:28
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-encoder-to-allow-for-arbitrary-types branch from 59415e7 to 420f102 Compare October 11, 2024 09:28
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-contract-instance-to-include-public-keys branch from b990dcb to a8d3482 Compare October 11, 2024 10:10
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-encoder-to-allow-for-arbitrary-types branch from 420f102 to 1b88305 Compare October 11, 2024 10:10
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-contract-instance-to-include-public-keys branch from a8d3482 to 19b4b1e Compare October 11, 2024 11:56
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-encoder-to-allow-for-arbitrary-types branch from 1b88305 to abed05d Compare October 11, 2024 11:56
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-contract-instance-to-include-public-keys branch from 19b4b1e to f28bbe2 Compare October 11, 2024 13:03
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-encoder-to-allow-for-arbitrary-types branch from abed05d to 70ad4ab Compare October 11, 2024 13:03
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-contract-instance-to-include-public-keys branch from 2b7ba33 to 3ec4e76 Compare October 11, 2024 13:34
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-encoder-to-allow-for-arbitrary-types branch 2 times, most recently from 94eb311 to e2b01a0 Compare October 11, 2024 13:48
@sklppy88 sklppy88 changed the base branch from ek/feat/new-address-implementation/modify-contract-instance-to-include-public-keys to ek/feat/new-address-implementation/modify-note-processors-and-synchronizers-to-use-complete-address October 11, 2024 13:48
@sklppy88 sklppy88 removed the request for review from fcarreiro October 11, 2024 14:02
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-note-processors-and-synchronizers-to-use-complete-address branch from ba1b8d3 to 6f0a5bb Compare October 11, 2024 16:14
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-encoder-to-allow-for-arbitrary-types branch from e2b01a0 to f81fdd9 Compare October 11, 2024 16:14
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-note-processors-and-synchronizers-to-use-complete-address branch from 6f0a5bb to 592b7ce Compare October 11, 2024 17:38
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-encoder-to-allow-for-arbitrary-types branch from f81fdd9 to 0487493 Compare October 11, 2024 17:38
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-note-processors-and-synchronizers-to-use-complete-address branch from 592b7ce to 1d1a0d6 Compare October 11, 2024 21:38
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-encoder-to-allow-for-arbitrary-types branch from 0487493 to 90adadb Compare October 11, 2024 21:38
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-note-processors-and-synchronizers-to-use-complete-address branch 9 times, most recently from 711bfa2 to 951ddad Compare October 14, 2024 14:51
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-encoder-to-allow-for-arbitrary-types branch from 90adadb to f1aad52 Compare October 14, 2024 15:27
Base automatically changed from ek/feat/new-address-implementation/modify-note-processors-and-synchronizers-to-use-complete-address to master October 14, 2024 15:48
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-encoder-to-allow-for-arbitrary-types branch from f1aad52 to ea2ca9e Compare October 14, 2024 15:52
@github-actions GitHub Actions
Copy link
Contributor

Changes to circuit sizes

Generated at commit: 8966f89d8f45fe6e8fbba82411ae988c3fbf93cf, compared to commit: 155b40b67616387f183dcb05d6ab08e9e4c3ab72

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_empty 0 ➖ 0.00% +936,476 ❌ +26863.91%
private_kernel_tail +62 ❌ +1.33% +524 ❌ +5.81%
private_kernel_tail_to_public +62 ❌ +0.21% +523 ❌ +1.32%
private_kernel_inner +61 ❌ +0.14% +523 ❌ +1.00%
private_kernel_reset_4_4_4_4_4_4_4_4_1 +59 ❌ +0.17% +519 ❌ +0.70%
private_kernel_reset +59 ❌ +0.06% +520 ❌ +0.11%
rollup_merge +122 ❌ +3.32% +1,051 ❌ +0.06%
rollup_root +120 ❌ +1.68% +1,050 ❌ +0.06%
rollup_block_merge +120 ❌ +1.67% +1,048 ❌ +0.06%
rollup_block_root +128 ❌ +3.10% +1,513 ❌ +0.05%
parity_root +28 ❌ +0.52% +1,847 ❌ +0.05%
public_kernel_merge +62 ❌ +0.12% +520 ❌ +0.05%
public_kernel_tail +9 ❌ +0.00% +461 ❌ +0.02%
rollup_base +58 ❌ +0.01% +518 ❌ +0.02%
empty_nested 0 ➖ +∞% -5 ✅ -23.81%
empty_nested_simulated 0 ➖ 0.00% -5 ✅ -23.81%
private_kernel_empty_simulated 0 ➖ 0.00% -5 ✅ -23.81%
Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_empty 671 (0) 0.00% 939,962 (+936,476) +26863.91%
private_kernel_tail 4,710 (+62) +1.33% 9,545 (+524) +5.81%
private_kernel_tail_to_public 29,890 (+62) +0.21% 40,033 (+523) +1.32%
private_kernel_inner 44,103 (+61) +0.14% 52,877 (+523) +1.00%
private_kernel_reset_4_4_4_4_4_4_4_4_1 34,956 (+59) +0.17% 74,998 (+519) +0.70%
private_kernel_reset 91,992 (+59) +0.06% 468,250 (+520) +0.11%
rollup_merge 3,795 (+122) +3.32% 1,897,297 (+1,051) +0.06%
rollup_root 7,273 (+120) +1.68% 1,900,452 (+1,050) +0.06%
rollup_block_merge 7,289 (+120) +1.67% 1,900,466 (+1,048) +0.06%
rollup_block_root 4,252 (+128) +3.10% 2,838,780 (+1,513) +0.05%
parity_root 5,427 (+28) +0.52% 3,776,972 (+1,847) +0.05%
public_kernel_merge 53,594 (+62) +0.12% 1,104,122 (+520) +0.05%
public_kernel_tail 258,433 (+9) +0.00% 2,270,721 (+461) +0.02%
rollup_base 483,231 (+58) +0.01% 3,356,255 (+518) +0.02%
empty_nested 0 (0) +∞% 16 (-5) -23.81%
empty_nested_simulated 1 (0) 0.00% 16 (-5) -23.81%
private_kernel_empty_simulated 1 (0) 0.00% 16 (-5) -23.81%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbanks12 dbanks12 dbanks12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sklppy88 @dbanks12