Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: modify note processors and synchronizers to use complete address #9152

Conversation

sklppy88
Copy link
Contributor

@sklppy88 sklppy88 commented Oct 10, 2024

I am modifying the note processors and synchronizers to use a complete address, instead of purely using the aztecaddress. This is because in the new address scheme, to decrypt, we will require the preaddress (a future member of the complete address), as well as the ivsk to calculate the "secret" of the address point. This is just scaffolding to be able to make the decrypting changes in the future.

The note processors specifically need this, but the synchronizer previously did not have it, but it was fetching the complete address anyways from the pxe db.

Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sklppy88 and the rest of your teammates on Graphite Graphite

@sklppy88 sklppy88 changed the title init refactor: modify note processors and synchronizers to use complete address Oct 10, 2024
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/move-contract-stuff-to-circuits-js branch from 607a4b3 to 646fa53 Compare October 11, 2024 09:00
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-note-processors-and-synchronizers-to-use-complete-address branch from d87c607 to 748074d Compare October 11, 2024 09:00
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/move-contract-stuff-to-circuits-js branch from 646fa53 to f5303e3 Compare October 11, 2024 09:28
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-note-processors-and-synchronizers-to-use-complete-address branch from 748074d to 63459c1 Compare October 11, 2024 09:28
@sklppy88 sklppy88 marked this pull request as ready for review October 11, 2024 09:29
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/move-contract-stuff-to-circuits-js branch from f5303e3 to 3842941 Compare October 11, 2024 10:10
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-note-processors-and-synchronizers-to-use-complete-address branch from 63459c1 to 6228f2c Compare October 11, 2024 10:10
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/move-contract-stuff-to-circuits-js branch from 3842941 to 322d621 Compare October 11, 2024 10:15
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-note-processors-and-synchronizers-to-use-complete-address branch from 6228f2c to 31098a8 Compare October 11, 2024 10:16
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/move-contract-stuff-to-circuits-js branch from 322d621 to c5375c6 Compare October 11, 2024 13:01
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-note-processors-and-synchronizers-to-use-complete-address branch from 31098a8 to 21973ae Compare October 11, 2024 13:03
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/move-contract-stuff-to-circuits-js branch from c5375c6 to 1e5a92b Compare October 11, 2024 13:34
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-note-processors-and-synchronizers-to-use-complete-address branch from 21973ae to ba1b8d3 Compare October 11, 2024 13:34
Copy link
Contributor

@dbanks12 dbanks12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't consider myself an authority on these parts of the code, but this looks fine to me!

@sklppy88 sklppy88 removed the request for review from fcarreiro October 11, 2024 14:02
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/move-contract-stuff-to-circuits-js branch from 1e5a92b to 7320bdb Compare October 11, 2024 16:14
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-note-processors-and-synchronizers-to-use-complete-address branch from ba1b8d3 to 6f0a5bb Compare October 11, 2024 16:14
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/move-contract-stuff-to-circuits-js branch from 7320bdb to b1d4492 Compare October 11, 2024 17:38
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-note-processors-and-synchronizers-to-use-complete-address branch from 6f0a5bb to 592b7ce Compare October 11, 2024 17:38
Base automatically changed from ek/feat/new-address-implementation/move-contract-stuff-to-circuits-js to master October 11, 2024 18:35
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-note-processors-and-synchronizers-to-use-complete-address branch 2 times, most recently from 1d1a0d6 to 03c2acd Compare October 14, 2024 11:17
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-note-processors-and-synchronizers-to-use-complete-address branch 7 times, most recently from 1269227 to 711bfa2 Compare October 14, 2024 14:51
@sklppy88 sklppy88 force-pushed the ek/feat/new-address-implementation/modify-note-processors-and-synchronizers-to-use-complete-address branch from 711bfa2 to 951ddad Compare October 14, 2024 14:51
@sklppy88 sklppy88 added the e2e-all CI: Enables this CI job. label Oct 14, 2024
@sklppy88 sklppy88 merged commit 730d90f into master Oct 14, 2024
105 of 137 checks passed
@sklppy88 sklppy88 deleted the ek/feat/new-address-implementation/modify-note-processors-and-synchronizers-to-use-complete-address branch October 14, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-all CI: Enables this CI job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants