-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: modify note processors and synchronizers to use complete address #9152
refactor: modify note processors and synchronizers to use complete address #9152
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
607a4b3
to
646fa53
Compare
d87c607
to
748074d
Compare
646fa53
to
f5303e3
Compare
748074d
to
63459c1
Compare
f5303e3
to
3842941
Compare
63459c1
to
6228f2c
Compare
3842941
to
322d621
Compare
6228f2c
to
31098a8
Compare
322d621
to
c5375c6
Compare
31098a8
to
21973ae
Compare
c5375c6
to
1e5a92b
Compare
21973ae
to
ba1b8d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't consider myself an authority on these parts of the code, but this looks fine to me!
1e5a92b
to
7320bdb
Compare
ba1b8d3
to
6f0a5bb
Compare
7320bdb
to
b1d4492
Compare
6f0a5bb
to
592b7ce
Compare
1d1a0d6
to
03c2acd
Compare
1269227
to
711bfa2
Compare
711bfa2
to
951ddad
Compare
I am modifying the note processors and synchronizers to use a complete address, instead of purely using the aztecaddress. This is because in the new address scheme, to decrypt, we will require the preaddress (a future member of the complete address), as well as the ivsk to calculate the "secret" of the address point. This is just scaffolding to be able to make the decrypting changes in the future.
The note processors specifically need this, but the synchronizer previously did not have it, but it was fetching the complete address anyways from the pxe db.