Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Sphere from generation to credscanfix #25541

Merged
merged 5 commits into from
Jul 15, 2024
Merged

Conversation

azure-powershell-bot
Copy link
Collaborator

Description

Migrate Sphere from generation to credscanfix
The last commit of src/Sphere in generation is:
commit e16688c Author: JoyerJin [email protected] Date: Mon Jul 15 14:30:08 2024 +0800 Sphere Credscan issue fixing (#25537)

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Jul 15, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.Sphere
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzSphereCatalog Get-AzSphereCatalog Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzSphereCatalog Get-AzSphereCatalog changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzSphereCertificate Get-AzSphereCertificate Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzSphereCertificate Get-AzSphereCertificate changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzSphereDeployment Get-AzSphereDeployment Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzSphereDeployment Get-AzSphereDeployment changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzSphereDevice Get-AzSphereDevice Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzSphereDevice Get-AzSphereDevice changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzSphereDeviceGroup Get-AzSphereDeviceGroup Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzSphereDeviceGroup Get-AzSphereDeviceGroup changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzSphereImage Get-AzSphereImage Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzSphereImage Get-AzSphereImage changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzSphereProduct Get-AzSphereProduct Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzSphereProduct Get-AzSphereProduct changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzSphereCatalog Get-AzSphereCatalog Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzSphereCatalog Get-AzSphereCatalog changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzSphereCertificate Get-AzSphereCertificate Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzSphereCertificate Get-AzSphereCertificate changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzSphereDeployment Get-AzSphereDeployment Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzSphereDeployment Get-AzSphereDeployment changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzSphereDevice Get-AzSphereDevice Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzSphereDevice Get-AzSphereDevice changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzSphereDeviceGroup Get-AzSphereDeviceGroup Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzSphereDeviceGroup Get-AzSphereDeviceGroup changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzSphereImage Get-AzSphereImage Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzSphereImage Get-AzSphereImage changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzSphereProduct Get-AzSphereProduct Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzSphereProduct Get-AzSphereProduct changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@Nickcandy Nickcandy merged commit e2125e5 into credscanfix Jul 15, 2024
12 checks passed
@JoyerJin JoyerJin deleted the codegen/Sphere branch July 16, 2024 07:00
VeryEarly pushed a commit that referenced this pull request Jul 28, 2024
* [Credscanfix] Hiden Client Secret (#25535)

* Hiden Client Secret

* update changelog

* update changelog

* Move ConnectedKubernetes to credscanfix (#25542)

* Move DataBox to credscanfix (#25543)

* Move Qumulo to credscanfix (#25544)

* Move DataMigration to credscanfix (#25545)

* Move Workloads to credscanfix (#25546)

* Move NetworkCloud to credscanfix (#25547)

* Move DevCenter to credscanfix (#25548)

* Credscan issue fixing part of joyer (#25552)

* Migrate Sphere from generation to credscanfix (#25541)

* Move Sphere to credscanfix

* Update ChangeLog.md

* Update ChangeLog.md

* Update ChangeLog.md

* Update required Az.Accounts version

---------

Co-authored-by: NanxiangLiu <[email protected]>
Co-authored-by: JoyerJin <[email protected]>

* [Credscanfix] Fixed secrets exposure in example documentation (#25580)

* Fixed secrets exposure in example documentation

* update ConvertTo-SecureString examples and update changelog

* Fixed secrets exposure in example documentation

* update

* update

* update

* update

* remove changelog of credscan

* remove changelog of credscan

* remove changelog of credscan

* remove general secret

---------

Co-authored-by: lijinpei2008 <[email protected]>
Co-authored-by: Azure PowerShell <[email protected]>
Co-authored-by: JoyerJin <[email protected]>
github-actions bot pushed a commit that referenced this pull request Jul 28, 2024
* [Credscanfix] Hiden Client Secret (#25535)

* Hiden Client Secret

* update changelog

* update changelog

* Move ConnectedKubernetes to credscanfix (#25542)

* Move DataBox to credscanfix (#25543)

* Move Qumulo to credscanfix (#25544)

* Move DataMigration to credscanfix (#25545)

* Move Workloads to credscanfix (#25546)

* Move NetworkCloud to credscanfix (#25547)

* Move DevCenter to credscanfix (#25548)

* Credscan issue fixing part of joyer (#25552)

* Migrate Sphere from generation to credscanfix (#25541)

* Move Sphere to credscanfix

* Update ChangeLog.md

* Update ChangeLog.md

* Update ChangeLog.md

* Update required Az.Accounts version

---------

Co-authored-by: NanxiangLiu <[email protected]>
Co-authored-by: JoyerJin <[email protected]>

* [Credscanfix] Fixed secrets exposure in example documentation (#25580)

* Fixed secrets exposure in example documentation

* update ConvertTo-SecureString examples and update changelog

* Fixed secrets exposure in example documentation

* update

* update

* update

* update

* remove changelog of credscan

* remove changelog of credscan

* remove changelog of credscan

* remove general secret

---------

Co-authored-by: lijinpei2008 <[email protected]>
Co-authored-by: Azure PowerShell <[email protected]>
Co-authored-by: JoyerJin <[email protected]>
@VeryEarly VeryEarly mentioned this pull request Aug 5, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants