Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Workloads from generation to credscanfix #25546

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

azure-powershell-bot
Copy link
Collaborator

Description

Migrate Workloads from generation to credscanfix
The last commit of src/Workloads in generation is:
commit c7fef6f Author: lijinpei2008 [email protected] Date: Mon Jul 15 15:51:28 2024 +0800 Hiden Client Secret (#25539)

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Jul 15, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Az.Workloads
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Help Example Check
❌PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
New-AzWorkloadsProviderSapNetWeaverInstanceObject 1 1 Invalid_Cmdlet New-AzWorkloadsProviderSapNetWeaverInstanceObject is not a valid command name. New-AzWorkloadsProviderSapNetWeaverInstanceObject -SapClientId 000 -SapHostFileEntry '['10.0.82.4 l13appvm0.ams.azure.com l13appvm0','10.0.82.5 l13ascsvm.ams.azure.com l13ascsvm']' -SapHostname 10.0.82.4 -SapInstanceNr 00 -SapPassword $password -SapSid L13 -SapUsername AMSUSER -SslPreference Disabled Check the spell of New-AzWorkloadsProviderSapNetWeaverInstanceObject.
New-AzWorkloadsProviderSqlServerInstanceObject 1 1 Invalid_Cmdlet New-AzWorkloadsProviderSqlServerInstanceObject is not a valid command name. New-AzWorkloadsProviderSqlServerInstanceObject -Password $password -Port 1433 -Username ams -Hostname 10.1.14.5 -SapSid X00 -SslPreference Disabled Check the spell of New-AzWorkloadsProviderSqlServerInstanceObject.
New-AzWorkloadsProviderSapNetWeaverInstanceObject 1 1 Invalid_Cmdlet New-AzWorkloadsProviderSapNetWeaverInstanceObject is not a valid command name. New-AzWorkloadsProviderSapNetWeaverInstanceObject -SapClientId 000 -SapHostFileEntry '['10.0.82.4 l13appvm0.ams.azure.com l13appvm0','10.0.82.5 l13ascsvm.ams.azure.com l13ascsvm']' -SapHostname 10.0.82.4 -SapInstanceNr 00 -SapPassword $password -SapSid L13 -SapUsername AMSUSER -SslPreference Disabled Check the spell of New-AzWorkloadsProviderSapNetWeaverInstanceObject.
New-AzWorkloadsProviderSqlServerInstanceObject 1 1 Invalid_Cmdlet New-AzWorkloadsProviderSqlServerInstanceObject is not a valid command name. New-AzWorkloadsProviderSqlServerInstanceObject -Password $password -Port 1433 -Username ams -Hostname 10.1.14.5 -SapSid X00 -SslPreference Disabled Check the spell of New-AzWorkloadsProviderSqlServerInstanceObject.
❌Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
New-AzWorkloadsProviderSapNetWeaverInstanceObject 1 1 Invalid_Cmdlet New-AzWorkloadsProviderSapNetWeaverInstanceObject is not a valid command name. New-AzWorkloadsProviderSapNetWeaverInstanceObject -SapClientId 000 -SapHostFileEntry '['10.0.82.4 l13appvm0.ams.azure.com l13appvm0','10.0.82.5 l13ascsvm.ams.azure.com l13ascsvm']' -SapHostname 10.0.82.4 -SapInstanceNr 00 -SapPassword $password -SapSid L13 -SapUsername AMSUSER -SslPreference Disabled Check the spell of New-AzWorkloadsProviderSapNetWeaverInstanceObject.
New-AzWorkloadsProviderSqlServerInstanceObject 1 1 Invalid_Cmdlet New-AzWorkloadsProviderSqlServerInstanceObject is not a valid command name. New-AzWorkloadsProviderSqlServerInstanceObject -Password $password -Port 1433 -Username ams -Hostname 10.1.14.5 -SapSid X00 -SslPreference Disabled Check the spell of New-AzWorkloadsProviderSqlServerInstanceObject.
New-AzWorkloadsProviderSapNetWeaverInstanceObject 1 1 Invalid_Cmdlet New-AzWorkloadsProviderSapNetWeaverInstanceObject is not a valid command name. New-AzWorkloadsProviderSapNetWeaverInstanceObject -SapClientId 000 -SapHostFileEntry '['10.0.82.4 l13appvm0.ams.azure.com l13appvm0','10.0.82.5 l13ascsvm.ams.azure.com l13ascsvm']' -SapHostname 10.0.82.4 -SapInstanceNr 00 -SapPassword $password -SapSid L13 -SapUsername AMSUSER -SslPreference Disabled Check the spell of New-AzWorkloadsProviderSapNetWeaverInstanceObject.
New-AzWorkloadsProviderSqlServerInstanceObject 1 1 Invalid_Cmdlet New-AzWorkloadsProviderSqlServerInstanceObject is not a valid command name. New-AzWorkloadsProviderSqlServerInstanceObject -Password $password -Port 1433 -Username ams -Hostname 10.1.14.5 -SapSid X00 -SslPreference Disabled Check the spell of New-AzWorkloadsProviderSqlServerInstanceObject.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.Workloads. Add a changelog record under Upcoming Release section with past tense.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.Workloads. Add a changelog record under Upcoming Release section with past tense.
❌UX Metadata Check
❌PowerShell Core - Windows
Type Module ResourceType SubResourceType Command Description
Az.Workloads Microsoft.Workloads monitors-providerInstances Get-AzWorkloadsProviderInstance Cmdlet Get-AzWorkloadsProviderInstance is not contained in Az.Workloads.
Az.Workloads Microsoft.Workloads monitors-providerInstances Remove-AzWorkloadsProviderInstance Cmdlet Remove-AzWorkloadsProviderInstance is not contained in Az.Workloads.
Az.Workloads Microsoft.Workloads monitors Get-AzWorkloadsMonitor Cmdlet Get-AzWorkloadsMonitor is not contained in Az.Workloads.
Az.Workloads Microsoft.Workloads monitors Get-AzWorkloadsSapLandscapeMonitor Cmdlet Get-AzWorkloadsSapLandscapeMonitor is not contained in Az.Workloads.
Az.Workloads Microsoft.Workloads monitors Remove-AzWorkloadsMonitor Cmdlet Remove-AzWorkloadsMonitor is not contained in Az.Workloads.
Az.Workloads Microsoft.Workloads monitors Remove-AzWorkloadsSapLandscapeMonitor Cmdlet Remove-AzWorkloadsSapLandscapeMonitor is not contained in Az.Workloads.
Az.Workloads Microsoft.Workloads sapVirtualInstances-applicationInstances Get-AzWorkloadsSapApplicationInstance Cmdlet Get-AzWorkloadsSapApplicationInstance is not contained in Az.Workloads.
Az.Workloads Microsoft.Workloads sapVirtualInstances-applicationInstances Start-AzWorkloadsSapApplicationInstance Cmdlet Start-AzWorkloadsSapApplicationInstance is not contained in Az.Workloads.
Az.Workloads Microsoft.Workloads sapVirtualInstances-centralInstances Get-AzWorkloadsSapCentralInstance Cmdlet Get-AzWorkloadsSapCentralInstance is not contained in Az.Workloads.
Az.Workloads Microsoft.Workloads sapVirtualInstances-centralInstances Start-AzWorkloadsSapCentralInstance Cmdlet Start-AzWorkloadsSapCentralInstance is not contained in Az.Workloads.
Az.Workloads Microsoft.Workloads sapVirtualInstances-databaseInstances Get-AzWorkloadsSapDatabaseInstance Cmdlet Get-AzWorkloadsSapDatabaseInstance is not contained in Az.Workloads.
Az.Workloads Microsoft.Workloads sapVirtualInstances-databaseInstances Start-AzWorkloadsSapDatabaseInstance Cmdlet Start-AzWorkloadsSapDatabaseInstance is not contained in Az.Workloads.
Az.Workloads Microsoft.Workloads sapVirtualInstances Get-AzWorkloadsSapVirtualInstance Cmdlet Get-AzWorkloadsSapVirtualInstance is not contained in Az.Workloads.
Az.Workloads Microsoft.Workloads sapVirtualInstances Remove-AzWorkloadsSapVirtualInstance Cmdlet Remove-AzWorkloadsSapVirtualInstance is not contained in Az.Workloads.
Az.Workloads Microsoft.Workloads sapVirtualInstances Start-AzWorkloadsSapVirtualInstance Cmdlet Start-AzWorkloadsSapVirtualInstance is not contained in Az.Workloads.
❌Windows PowerShell - Windows
Type Module ResourceType SubResourceType Command Description
Az.Workloads Microsoft.Workloads monitors-providerInstances Get-AzWorkloadsProviderInstance Cmdlet Get-AzWorkloadsProviderInstance is not contained in Az.Workloads.
Az.Workloads Microsoft.Workloads monitors-providerInstances Remove-AzWorkloadsProviderInstance Cmdlet Remove-AzWorkloadsProviderInstance is not contained in Az.Workloads.
Az.Workloads Microsoft.Workloads monitors Get-AzWorkloadsMonitor Cmdlet Get-AzWorkloadsMonitor is not contained in Az.Workloads.
Az.Workloads Microsoft.Workloads monitors Get-AzWorkloadsSapLandscapeMonitor Cmdlet Get-AzWorkloadsSapLandscapeMonitor is not contained in Az.Workloads.
Az.Workloads Microsoft.Workloads monitors Remove-AzWorkloadsMonitor Cmdlet Remove-AzWorkloadsMonitor is not contained in Az.Workloads.
Az.Workloads Microsoft.Workloads monitors Remove-AzWorkloadsSapLandscapeMonitor Cmdlet Remove-AzWorkloadsSapLandscapeMonitor is not contained in Az.Workloads.
Az.Workloads Microsoft.Workloads sapVirtualInstances-applicationInstances Get-AzWorkloadsSapApplicationInstance Cmdlet Get-AzWorkloadsSapApplicationInstance is not contained in Az.Workloads.
Az.Workloads Microsoft.Workloads sapVirtualInstances-applicationInstances Start-AzWorkloadsSapApplicationInstance Cmdlet Start-AzWorkloadsSapApplicationInstance is not contained in Az.Workloads.
Az.Workloads Microsoft.Workloads sapVirtualInstances-centralInstances Get-AzWorkloadsSapCentralInstance Cmdlet Get-AzWorkloadsSapCentralInstance is not contained in Az.Workloads.
Az.Workloads Microsoft.Workloads sapVirtualInstances-centralInstances Start-AzWorkloadsSapCentralInstance Cmdlet Start-AzWorkloadsSapCentralInstance is not contained in Az.Workloads.
Az.Workloads Microsoft.Workloads sapVirtualInstances-databaseInstances Get-AzWorkloadsSapDatabaseInstance Cmdlet Get-AzWorkloadsSapDatabaseInstance is not contained in Az.Workloads.
Az.Workloads Microsoft.Workloads sapVirtualInstances-databaseInstances Start-AzWorkloadsSapDatabaseInstance Cmdlet Start-AzWorkloadsSapDatabaseInstance is not contained in Az.Workloads.
Az.Workloads Microsoft.Workloads sapVirtualInstances Get-AzWorkloadsSapVirtualInstance Cmdlet Get-AzWorkloadsSapVirtualInstance is not contained in Az.Workloads.
Az.Workloads Microsoft.Workloads sapVirtualInstances Remove-AzWorkloadsSapVirtualInstance Cmdlet Remove-AzWorkloadsSapVirtualInstance is not contained in Az.Workloads.
Az.Workloads Microsoft.Workloads sapVirtualInstances Start-AzWorkloadsSapVirtualInstance Cmdlet Start-AzWorkloadsSapVirtualInstance is not contained in Az.Workloads.
️✔️Test
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@Nickcandy Nickcandy merged commit 9e2c1eb into credscanfix Jul 15, 2024
4 of 12 checks passed
VeryEarly pushed a commit that referenced this pull request Jul 28, 2024
* [Credscanfix] Hiden Client Secret (#25535)

* Hiden Client Secret

* update changelog

* update changelog

* Move ConnectedKubernetes to credscanfix (#25542)

* Move DataBox to credscanfix (#25543)

* Move Qumulo to credscanfix (#25544)

* Move DataMigration to credscanfix (#25545)

* Move Workloads to credscanfix (#25546)

* Move NetworkCloud to credscanfix (#25547)

* Move DevCenter to credscanfix (#25548)

* Credscan issue fixing part of joyer (#25552)

* Migrate Sphere from generation to credscanfix (#25541)

* Move Sphere to credscanfix

* Update ChangeLog.md

* Update ChangeLog.md

* Update ChangeLog.md

* Update required Az.Accounts version

---------

Co-authored-by: NanxiangLiu <[email protected]>
Co-authored-by: JoyerJin <[email protected]>

* [Credscanfix] Fixed secrets exposure in example documentation (#25580)

* Fixed secrets exposure in example documentation

* update ConvertTo-SecureString examples and update changelog

* Fixed secrets exposure in example documentation

* update

* update

* update

* update

* remove changelog of credscan

* remove changelog of credscan

* remove changelog of credscan

* remove general secret

---------

Co-authored-by: lijinpei2008 <[email protected]>
Co-authored-by: Azure PowerShell <[email protected]>
Co-authored-by: JoyerJin <[email protected]>
github-actions bot pushed a commit that referenced this pull request Jul 28, 2024
* [Credscanfix] Hiden Client Secret (#25535)

* Hiden Client Secret

* update changelog

* update changelog

* Move ConnectedKubernetes to credscanfix (#25542)

* Move DataBox to credscanfix (#25543)

* Move Qumulo to credscanfix (#25544)

* Move DataMigration to credscanfix (#25545)

* Move Workloads to credscanfix (#25546)

* Move NetworkCloud to credscanfix (#25547)

* Move DevCenter to credscanfix (#25548)

* Credscan issue fixing part of joyer (#25552)

* Migrate Sphere from generation to credscanfix (#25541)

* Move Sphere to credscanfix

* Update ChangeLog.md

* Update ChangeLog.md

* Update ChangeLog.md

* Update required Az.Accounts version

---------

Co-authored-by: NanxiangLiu <[email protected]>
Co-authored-by: JoyerJin <[email protected]>

* [Credscanfix] Fixed secrets exposure in example documentation (#25580)

* Fixed secrets exposure in example documentation

* update ConvertTo-SecureString examples and update changelog

* Fixed secrets exposure in example documentation

* update

* update

* update

* update

* remove changelog of credscan

* remove changelog of credscan

* remove changelog of credscan

* remove general secret

---------

Co-authored-by: lijinpei2008 <[email protected]>
Co-authored-by: Azure PowerShell <[email protected]>
Co-authored-by: JoyerJin <[email protected]>
@VeryEarly VeryEarly mentioned this pull request Aug 5, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants