Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Batch CosmosDB DataFactory DeviceProvisioningServices IotHub KeyVault ServiceFabric Sql Credscan issue fixing #25552

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

JoyerJin
Copy link
Contributor

@JoyerJin JoyerJin commented Jul 15, 2024

Description

fixing part of joyer

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Jul 15, 2024

️✔️Az.ApiManagement
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.Batch
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Get-AzBatchCertificate 1 1 Unassigned_Variable Get-AzBatchCertificate -BatchContext $Context is a null-valued parameter value. -BatchContext Assign value for $Context.
⚠️ Get-AzBatchCertificate 2 1 Unassigned_Variable Get-AzBatchCertificate -BatchContext $Context is a null-valued parameter value. -BatchContext Assign value for $Context.
⚠️ New-AzBatchCertificate 1 1 Unassigned_Variable New-AzBatchCertificate -BatchContext $Context is a null-valued parameter value. -BatchContext Assign value for $Context.
⚠️Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Get-AzBatchCertificate 1 1 Unassigned_Variable Get-AzBatchCertificate -BatchContext $Context is a null-valued parameter value. -BatchContext Assign value for $Context.
⚠️ Get-AzBatchCertificate 2 1 Unassigned_Variable Get-AzBatchCertificate -BatchContext $Context is a null-valued parameter value. -BatchContext Assign value for $Context.
⚠️ New-AzBatchCertificate 1 1 Unassigned_Variable New-AzBatchCertificate -BatchContext $Context is a null-valued parameter value. -BatchContext Assign value for $Context.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.CosmosDB
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.DataFactory
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ New-AzDataFactoryEncryptValue 3 1 Unassigned_Variable ConvertTo-SecureString -String $string is a null-valued parameter value. -String Assign value for $string.
⚠️ New-AzDataFactoryEncryptValue 5 2 Unassigned_Variable New-AzDataFactoryEncryptValue -ResourceGroupName $RGName is a null-valued parameter value. -ResourceGroupName Assign value for $RGName.
⚠️ New-AzDataFactoryEncryptValue 5 2 Unassigned_Variable New-AzDataFactoryEncryptValue -DataFactoryName $DFName is a null-valued parameter value. -DataFactoryName Assign value for $DFName.
⚠️ New-AzDataFactoryEncryptValue 5 2 Unassigned_Variable New-AzDataFactoryEncryptValue -GatewayName $Gateway is a null-valued parameter value. -GatewayName Assign value for $Gateway.
⚠️Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ New-AzDataFactoryEncryptValue 3 1 Unassigned_Variable ConvertTo-SecureString -String $string is a null-valued parameter value. -String Assign value for $string.
⚠️ New-AzDataFactoryEncryptValue 5 2 Unassigned_Variable New-AzDataFactoryEncryptValue -ResourceGroupName $RGName is a null-valued parameter value. -ResourceGroupName Assign value for $RGName.
⚠️ New-AzDataFactoryEncryptValue 5 2 Unassigned_Variable New-AzDataFactoryEncryptValue -DataFactoryName $DFName is a null-valued parameter value. -DataFactoryName Assign value for $DFName.
⚠️ New-AzDataFactoryEncryptValue 5 2 Unassigned_Variable New-AzDataFactoryEncryptValue -GatewayName $Gateway is a null-valued parameter value. -GatewayName Assign value for $Gateway.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.DeviceProvisioningServices
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.IotHub
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.KeyVault
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.ServiceFabric
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ New-AzServiceFabricCluster 1 9 Unassigned_Variable New-AzServiceFabricCluster -CertificatePassword $pass is a null-valued parameter value. -CertificatePassword Assign value for $pass.
⚠️Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ New-AzServiceFabricCluster 1 9 Unassigned_Variable New-AzServiceFabricCluster -CertificatePassword $pass is a null-valued parameter value. -CertificatePassword Assign value for $pass.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@Nickcandy Nickcandy merged commit 18d0d3c into credscanfix Jul 15, 2024
10 of 12 checks passed
@JoyerJin JoyerJin deleted the credscanfix-joyer branch July 16, 2024 07:00
VeryEarly pushed a commit that referenced this pull request Jul 28, 2024
* [Credscanfix] Hiden Client Secret (#25535)

* Hiden Client Secret

* update changelog

* update changelog

* Move ConnectedKubernetes to credscanfix (#25542)

* Move DataBox to credscanfix (#25543)

* Move Qumulo to credscanfix (#25544)

* Move DataMigration to credscanfix (#25545)

* Move Workloads to credscanfix (#25546)

* Move NetworkCloud to credscanfix (#25547)

* Move DevCenter to credscanfix (#25548)

* Credscan issue fixing part of joyer (#25552)

* Migrate Sphere from generation to credscanfix (#25541)

* Move Sphere to credscanfix

* Update ChangeLog.md

* Update ChangeLog.md

* Update ChangeLog.md

* Update required Az.Accounts version

---------

Co-authored-by: NanxiangLiu <[email protected]>
Co-authored-by: JoyerJin <[email protected]>

* [Credscanfix] Fixed secrets exposure in example documentation (#25580)

* Fixed secrets exposure in example documentation

* update ConvertTo-SecureString examples and update changelog

* Fixed secrets exposure in example documentation

* update

* update

* update

* update

* remove changelog of credscan

* remove changelog of credscan

* remove changelog of credscan

* remove general secret

---------

Co-authored-by: lijinpei2008 <[email protected]>
Co-authored-by: Azure PowerShell <[email protected]>
Co-authored-by: JoyerJin <[email protected]>
github-actions bot pushed a commit that referenced this pull request Jul 28, 2024
* [Credscanfix] Hiden Client Secret (#25535)

* Hiden Client Secret

* update changelog

* update changelog

* Move ConnectedKubernetes to credscanfix (#25542)

* Move DataBox to credscanfix (#25543)

* Move Qumulo to credscanfix (#25544)

* Move DataMigration to credscanfix (#25545)

* Move Workloads to credscanfix (#25546)

* Move NetworkCloud to credscanfix (#25547)

* Move DevCenter to credscanfix (#25548)

* Credscan issue fixing part of joyer (#25552)

* Migrate Sphere from generation to credscanfix (#25541)

* Move Sphere to credscanfix

* Update ChangeLog.md

* Update ChangeLog.md

* Update ChangeLog.md

* Update required Az.Accounts version

---------

Co-authored-by: NanxiangLiu <[email protected]>
Co-authored-by: JoyerJin <[email protected]>

* [Credscanfix] Fixed secrets exposure in example documentation (#25580)

* Fixed secrets exposure in example documentation

* update ConvertTo-SecureString examples and update changelog

* Fixed secrets exposure in example documentation

* update

* update

* update

* update

* remove changelog of credscan

* remove changelog of credscan

* remove changelog of credscan

* remove general secret

---------

Co-authored-by: lijinpei2008 <[email protected]>
Co-authored-by: Azure PowerShell <[email protected]>
Co-authored-by: JoyerJin <[email protected]>
@VeryEarly VeryEarly mentioned this pull request Aug 5, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants