Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gallery_07_01 change #22920

Conversation

kangsun-ctrl
Copy link
Contributor

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
    

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@grizzlytheodore
Copy link
Member

/azp run net - mgmt - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@grizzlytheodore grizzlytheodore merged commit 7417c43 into Azure:feature/cplat-2021-07-01 Jul 29, 2021
grizzlytheodore added a commit that referenced this pull request Jul 29, 2021
* Update ci.mgmt.yml

dont install net core. matching main

* SDK changes for SuppressFailures  (#22220)

* init

* adding recorded test

* [Do not merge] SDK changes for ScaleIn Policy ForceDeletion (#22680)

* updated test

* regenerate after re-wording

* save (#22921)

* save (#22920)

* List SKUs API update for ExtendedLocation (#22907)

* generated files and updated test recording

* added validation for the negative case

Co-authored-by: zero\asager <[email protected]>

Co-authored-by: kamusta-msft <[email protected]>
Co-authored-by: Aishwarya C S <[email protected]>
Co-authored-by: kangsun-ctrl <[email protected]>
Co-authored-by: Andrew Sager <[email protected]>
Co-authored-by: zero\asager <[email protected]>
archerzz pushed a commit that referenced this pull request Sep 1, 2021
* update market place test to use avail offer/sku

* sdk re-generated with new version

* new recording

* new recordings

* recording failing diskrp tests

* fixing vmscenario_encryptionathost sku

* update recording. last one

* TestVmScaleSetRollingUpgradeAPI test new recording

* new skus file generated and recorded

* sdk generated with all the swagger changes from 2021-04-01

* new recording for new test

* sdk re-generated with new version

* new recording

* new recordings

* recording failing diskrp tests

* fixing vmscenario_encryptionathost sku

* update recording. last one

* update recordings to resolve conflics more easily

* Added sdk changed for VMCustomization (#22394)

* SDK related changes - VM Hibernation support feature (#22438)

* Add Hibernate Support related files

* update recording. last one

* Removed redeploy and updated test record

* reverting the changes for ultrassd check

Co-authored-by: Pavan Rachapudy <[email protected]>
Co-authored-by: Theodore Chang <[email protected]>

* updated with 2021-07-01 gallery

* new recordings for tests added in 2021-04-01

* Feature/cplat 2021 07 01 (#22950)

* Update ci.mgmt.yml

dont install net core. matching main

* SDK changes for SuppressFailures  (#22220)

* init

* adding recorded test

* [Do not merge] SDK changes for ScaleIn Policy ForceDeletion (#22680)

* updated test

* regenerate after re-wording

* save (#22921)

* save (#22920)

* List SKUs API update for ExtendedLocation (#22907)

* generated files and updated test recording

* added validation for the negative case

Co-authored-by: zero\asager <[email protected]>

Co-authored-by: kamusta-msft <[email protected]>
Co-authored-by: Aishwarya C S <[email protected]>
Co-authored-by: kangsun-ctrl <[email protected]>
Co-authored-by: Andrew Sager <[email protected]>
Co-authored-by: zero\asager <[email protected]>

* SDK changes for VMApps (#23026)

* init

* test changes

* UTs

* Moved VM Application profile test to its own class. Added playback for test

* saving changes

* added test recording for VMScaleSets

* Ensure that the playback succeededs by hard coding the region in the test.

Co-authored-by: Kashif Mustahsan <[email protected]>
Co-authored-by: Theodore Chang <[email protected]>

* last gen from swagger master

* customizations (#23514)

* add 2021-07-01 reference and update commit id for swagger

* nuget version update

Co-authored-by: raktdas <[email protected]>
Co-authored-by: pavanrachapudy <[email protected]>
Co-authored-by: Pavan Rachapudy <[email protected]>
Co-authored-by: kamusta-msft <[email protected]>
Co-authored-by: Aishwarya C S <[email protected]>
Co-authored-by: kangsun-ctrl <[email protected]>
Co-authored-by: Andrew Sager <[email protected]>
Co-authored-by: zero\asager <[email protected]>
Co-authored-by: Bhaskar Brahma <[email protected]>
Co-authored-by: Kashif Mustahsan <[email protected]>
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Mar 7, 2023
updated Resource ID in all example files for workload monitor (Azure#22920)

* updated Resoutce ID in all example files for workload monitor api versions

* updated type for providers in examples Azure Monitor for SAP  for api-version 2021-12-01-preview

* updated type for providers in examples Azure Monitor for SAP  for api-version 2022-11-01-preview

* updated type for providers in examples Azure Monitor for SAP  for api-version 2023-14-01

* updated type for monitor in examples Azure Monitor for SAP  for api-version 2021-12-01-preview

* updated type for monitor in examples Azure Monitor for SAP  for api-version 2022-12-01-preview

* updated type for monitor in examples Azure Monitor for SAP  for api-version 2023-04-01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants