SDK changes for VMApps #23026

D1v38om83r · 2021-07-31T00:06:50Z

Link to API PR Azure/azure-rest-api-specs#15061

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

Please open PR in Draft mode if it is:
- Work in progress or not intended to be merged.
- Encountering multiple pipeline failures and working on fixes.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

Include updated management metadata.
Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
If the check fails at the Verify Code Generation step, please ensure:
- Do not modify any code in generated folders.
- Do not selectively include/remove generated files in the PR.
- Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
  Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.
Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:
```
  `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
```

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

…r test

check-enforcer · 2021-07-31T00:17:02Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

For track 1 management-plane SDKs

Please open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification.

grizzlytheodore · 2021-08-02T19:33:13Z

sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/VirtualMachine.cs

@@ -192,6 +194,7 @@ public VirtualMachine(string location, string id = default(string), string name
            PlatformFaultDomain = platformFaultDomain;
            ScheduledEventsProfile = scheduledEventsProfile;
            UserData = userData;
+            ApplicationProfile = applicationProfile;


check for customization. (for theo)

grizzlytheodore · 2021-08-02T19:33:48Z

...e/Microsoft.Azure.Management.Compute/src/Generated/Models/VirtualMachineScaleSetVMProfile.cs

@@ -96,6 +96,7 @@ public VirtualMachineScaleSetVMProfile(VirtualMachineScaleSetOSProfile osProfile
            BillingProfile = billingProfile;
            ScheduledEventsProfile = scheduledEventsProfile;
            UserData = userData;
+            ApplicationProfile = applicationProfile;


check for custmoization

grizzlytheodore · 2021-08-02T19:33:59Z

sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/VirtualMachineUpdate.cs

@@ -184,6 +184,7 @@ public VirtualMachineUpdate(IDictionary<string, string> tags = default(IDictiona
            PlatformFaultDomain = platformFaultDomain;
            ScheduledEventsProfile = scheduledEventsProfile;
            UserData = userData;
+            ApplicationProfile = applicationProfile;


check for customization

…test.

…ure-sdk-for-net into dev/bhaskar/vmApps

* update market place test to use avail offer/sku * sdk re-generated with new version * new recording * new recordings * recording failing diskrp tests * fixing vmscenario_encryptionathost sku * update recording. last one * TestVmScaleSetRollingUpgradeAPI test new recording * new skus file generated and recorded * sdk generated with all the swagger changes from 2021-04-01 * new recording for new test * sdk re-generated with new version * new recording * new recordings * recording failing diskrp tests * fixing vmscenario_encryptionathost sku * update recording. last one * update recordings to resolve conflics more easily * Added sdk changed for VMCustomization (#22394) * SDK related changes - VM Hibernation support feature (#22438) * Add Hibernate Support related files * update recording. last one * Removed redeploy and updated test record * reverting the changes for ultrassd check Co-authored-by: Pavan Rachapudy <[email protected]> Co-authored-by: Theodore Chang <[email protected]> * updated with 2021-07-01 gallery * new recordings for tests added in 2021-04-01 * Feature/cplat 2021 07 01 (#22950) * Update ci.mgmt.yml dont install net core. matching main * SDK changes for SuppressFailures (#22220) * init * adding recorded test * [Do not merge] SDK changes for ScaleIn Policy ForceDeletion (#22680) * updated test * regenerate after re-wording * save (#22921) * save (#22920) * List SKUs API update for ExtendedLocation (#22907) * generated files and updated test recording * added validation for the negative case Co-authored-by: zero\asager <[email protected]> Co-authored-by: kamusta-msft <[email protected]> Co-authored-by: Aishwarya C S <[email protected]> Co-authored-by: kangsun-ctrl <[email protected]> Co-authored-by: Andrew Sager <[email protected]> Co-authored-by: zero\asager <[email protected]> * SDK changes for VMApps (#23026) * init * test changes * UTs * Moved VM Application profile test to its own class. Added playback for test * saving changes * added test recording for VMScaleSets * Ensure that the playback succeededs by hard coding the region in the test. Co-authored-by: Kashif Mustahsan <[email protected]> Co-authored-by: Theodore Chang <[email protected]> * last gen from swagger master * customizations (#23514) * add 2021-07-01 reference and update commit id for swagger * nuget version update Co-authored-by: raktdas <[email protected]> Co-authored-by: pavanrachapudy <[email protected]> Co-authored-by: Pavan Rachapudy <[email protected]> Co-authored-by: kamusta-msft <[email protected]> Co-authored-by: Aishwarya C S <[email protected]> Co-authored-by: kangsun-ctrl <[email protected]> Co-authored-by: Andrew Sager <[email protected]> Co-authored-by: zero\asager <[email protected]> Co-authored-by: Bhaskar Brahma <[email protected]> Co-authored-by: Kashif Mustahsan <[email protected]>

kamusta-msft and others added 6 commits July 9, 2021 14:55

init

1a439c7

test changes

84d777e

UTs

114cc7f

Moved VM Application profile test to its own class. Added playback fo…

7b0b6c7

…r test

saving changes

b5f1ec9

added test recording for VMScaleSets

d8ce528

D1v38om83r requested review from allenjzhang, m-nash, markcowl, nisha-bhatia and YalinLi0312 as code owners July 31, 2021 00:06

openapi-assignment-bot bot assigned m-nash Jul 31, 2021

ghost added the Compute label Jul 31, 2021

allenjzhang assigned grizzlytheodore and unassigned m-nash Aug 2, 2021

Merge branch 'feature/cplat-2021-07-01' into dev/bhaskar/vmApps

ff3f97a

grizzlytheodore reviewed Aug 2, 2021

View reviewed changes

D1v38om83r added 2 commits August 2, 2021 15:21

Ensure that the playback succeededs by hard coding the region in the …

6f6c389

…test.

Merge branch 'dev/bhaskar/vmApps' of https://github.com/D1v38om83r/az…

2b6315d

…ure-sdk-for-net into dev/bhaskar/vmApps

grizzlytheodore merged commit 7046061 into Azure:feature/cplat-2021-07-01 Aug 2, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SDK changes for VMApps #23026

SDK changes for VMApps #23026

D1v38om83r commented Jul 31, 2021

check-enforcer bot commented Jul 31, 2021

grizzlytheodore Aug 2, 2021

grizzlytheodore Aug 2, 2021

grizzlytheodore Aug 2, 2021

SDK changes for VMApps #23026

SDK changes for VMApps #23026

Conversation

D1v38om83r commented Jul 31, 2021

All SDK Contribution checklist:

General Guidelines and Best Practices

Testing Guidelines

SDK Generation Guidelines

Additional management plane SDK specific contribution checklist:

Management plane SDK Troubleshooting

Old outstanding PR cleanup

check-enforcer bot commented Jul 31, 2021

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

For track 1 management-plane SDKs

grizzlytheodore Aug 2, 2021

Choose a reason for hiding this comment

grizzlytheodore Aug 2, 2021

Choose a reason for hiding this comment

grizzlytheodore Aug 2, 2021

Choose a reason for hiding this comment