-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compute 2021-07-01 REST API version change #23511
Conversation
* Add Hibernate Support related files * update recording. last one * Removed redeploy and updated test record * reverting the changes for ultrassd check Co-authored-by: Pavan Rachapudy <[email protected]> Co-authored-by: Theodore Chang <[email protected]>
* Update ci.mgmt.yml dont install net core. matching main * SDK changes for SuppressFailures (#22220) * init * adding recorded test * [Do not merge] SDK changes for ScaleIn Policy ForceDeletion (#22680) * updated test * regenerate after re-wording * save (#22921) * save (#22920) * List SKUs API update for ExtendedLocation (#22907) * generated files and updated test recording * added validation for the negative case Co-authored-by: zero\asager <[email protected]> Co-authored-by: kamusta-msft <[email protected]> Co-authored-by: Aishwarya C S <[email protected]> Co-authored-by: kangsun-ctrl <[email protected]> Co-authored-by: Andrew Sager <[email protected]> Co-authored-by: zero\asager <[email protected]>
* init * test changes * UTs * Moved VM Application profile test to its own class. Added playback for test * saving changes * added test recording for VMScaleSets * Ensure that the playback succeededs by hard coding the region in the test. Co-authored-by: Kashif Mustahsan <[email protected]> Co-authored-by: Theodore Chang <[email protected]>
sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/IResourceSkusOperations.cs
Show resolved
Hide resolved
sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/IVirtualMachinesOperations.cs
Show resolved
Hide resolved
sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/IVirtualMachinesOperations.cs
Show resolved
Hide resolved
sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/VirtualMachine.cs
Show resolved
Hide resolved
...soft.Azure.Management.Compute/src/Generated/Models/VirtualMachineInstallPatchesParameters.cs
Show resolved
Hide resolved
sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/VirtualMachineUpdate.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some comments we need to resolve (most are about interface backward compatibility), before we can merge it. Thanks.
sdk/compute/Microsoft.Azure.Management.Compute/src/Customizations/VirtualMachine.cs
Show resolved
Hide resolved
sdk/compute/Microsoft.Azure.Management.Compute/src/Customizations/VirtualMachineUpdate.cs
Show resolved
Hide resolved
sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/VirtualMachine.cs
Show resolved
Hide resolved
...soft.Azure.Management.Compute/src/Generated/Models/VirtualMachineInstallPatchesParameters.cs
Show resolved
Hide resolved
sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/VirtualMachineUpdate.cs
Show resolved
Hide resolved
sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/ResourceSkusOperations.cs
Show resolved
Hide resolved
sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/VirtualMachinesOperations.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sandido @grizzlytheodore You're right. Codes under Generated
cannot be changed, and they could be worked around under Customization
. All comments are resolved. Thanks.
All SDK Contribution checklist:
Swagger PR adding 2021-07-01 version: Azure/azure-rest-api-specs#15479
This checklist is used to make sure that common guidelines for a pull request are followed.
Draft
mode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]
orAzure.ResourceManager.[RP]
Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new service
label and/or contact assigned reviewer.If the check fails at the
Verify Code Generation
step, please ensure:generate.ps1/cmd
to generate this PR instead of callingautorest
directly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1
. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1
to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.