Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute 2021-07-01 REST API version change #23511

Merged
merged 33 commits into from
Sep 1, 2021
Merged

Conversation

grizzlytheodore
Copy link
Member

@grizzlytheodore grizzlytheodore commented Aug 24, 2021

All SDK Contribution checklist:

Swagger PR adding 2021-07-01 version: Azure/azure-rest-api-specs#15479

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
    

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

grizzlytheodore and others added 29 commits June 21, 2021 22:44
* Add Hibernate Support related files

* update recording. last one

* Removed redeploy and updated test record

* reverting the changes for ultrassd check

Co-authored-by: Pavan Rachapudy <[email protected]>
Co-authored-by: Theodore Chang <[email protected]>
* Update ci.mgmt.yml

dont install net core. matching main

* SDK changes for SuppressFailures  (#22220)

* init

* adding recorded test

* [Do not merge] SDK changes for ScaleIn Policy ForceDeletion (#22680)

* updated test

* regenerate after re-wording

* save (#22921)

* save (#22920)

* List SKUs API update for ExtendedLocation (#22907)

* generated files and updated test recording

* added validation for the negative case

Co-authored-by: zero\asager <[email protected]>

Co-authored-by: kamusta-msft <[email protected]>
Co-authored-by: Aishwarya C S <[email protected]>
Co-authored-by: kangsun-ctrl <[email protected]>
Co-authored-by: Andrew Sager <[email protected]>
Co-authored-by: zero\asager <[email protected]>
* init

* test changes

* UTs

* Moved VM Application profile test to its own class. Added playback for test

* saving changes

* added test recording for VMScaleSets

* Ensure that the playback succeededs by hard coding the region in the test.

Co-authored-by: Kashif Mustahsan <[email protected]>
Co-authored-by: Theodore Chang <[email protected]>
@ghost ghost added the Compute label Aug 24, 2021
@grizzlytheodore grizzlytheodore changed the title Feature/cplat 2021 07 01 Compute 2021-07-01 REST API version change Aug 24, 2021
Copy link
Member

@archerzz archerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some comments we need to resolve (most are about interface backward compatibility), before we can merge it. Thanks.

@yungezz yungezz added the Mgmt This issue is related to a management-plane library. label Sep 1, 2021
Copy link
Member

@archerzz archerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sandido @grizzlytheodore You're right. Codes under Generated cannot be changed, and they could be worked around under Customization. All comments are resolved. Thanks.

@archerzz archerzz merged commit 4a23534 into main Sep 1, 2021
@archerzz archerzz deleted the feature/cplat-2021-07-01 branch September 1, 2021 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compute Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants