Support for optional Ultra disks #245
Conversation
|
MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
There was a problem hiding this comment.
Thanks for opening this pr, almost LGTM @digiserg , only some lint issues, we're sorting Terraform codes by some new rules, we can check our code on our local machine by running the following command:
$ docker run --rm -v $(pwd):/src -w /src mcr.microsoft.com/azterraform:latest make pre-commit
$ docker run --rm -v $(pwd):/src -w /src mcr.microsoft.com/azterraform:latest make pr-checkThanks for your understanding.
|
MAIN BRANCH PUSH DETECTED DUE TO #230, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
|
MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
1 similar comment
|
MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
|
Sorry @digiserg we have some issues on our self-hosted github runner, I'll run the test when we fix the runner. |
|
MAIN BRANCH PUSH DETECTED DUE TO #253, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
|
MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
|
MAIN BRANCH PUSH DETECTED DUE TO #249, THIS PR NEED TO BE UPDATED TO TRIGGER CI. |
|
Sorry for the late reply @digiserg, we've just fixed our self-hosted GH runner and we're ready to test and merge this pr. Would you please revert your change to changelog since we have conflict here? Thanks! |
Redo of #242
Sorry for the inconvenience.