Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update azurerm provider's restriction. #248

Merged
merged 2 commits into from
Sep 30, 2022
Merged

Update azurerm provider's restriction. #248

merged 2 commits into from
Sep 30, 2022

Conversation

lonegunmanb
Copy link
Member

@lonegunmanb lonegunmanb commented Sep 14, 2022 •
edited
Loading

Limit azurerm provider's version since enforce_private_link_endpoint_network_policies in azurerm_subnet will be removed in 4.x.
This pr also loosen the azurerm provider's restriction.

@github-actions
Copy link
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@github-actions
Copy link
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #253, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@github-actions
Copy link
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@github-actions
Copy link
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #249, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@github-actions
Copy link
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #245, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@github-actions
Copy link
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

1 similar comment
@github-actions
Copy link
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@github-actions
Copy link
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #259, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@github-actions
Copy link
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #262, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@github-actions
Copy link
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #260, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@github-actions
Copy link
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #251, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@lonegunmanb
Limit azurerm provider's version since `enforce_private_link_endpoint…
0181d40 
…_network_policies` in `azurerm_subnet` will be removed in 4.x.
@github-actions
Copy link
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@lonegunmanb lonegunmanb temporarily deployed to acctests September 30, 2022 01:39 Inactive
@lonegunmanb lonegunmanb changed the title Limit azurerm provider's version in example code Update azurerm provider's restriction. Sep 30, 2022
@lonegunmanb lonegunmanb temporarily deployed to acctests September 30, 2022 07:54 Inactive
@github-actions
Copy link
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #256, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@github-actions
Copy link
Contributor

MAIN BRANCH PUSH DETECTED DUE TO #, THIS PR NEED TO BE UPDATED TO TRIGGER CI.

@zioproto
Copy link
Collaborator

I tested the following:

 module "aks" {
-  source                            = "Azure/aks/azurerm"
+  source                            = "git::https://github.com/lonegunmanb/terraform-azurerm-aks.git?ref=limit-example-provider-version"
[....]

The terraform init -upgrade works. LGTM

@lonegunmanb lonegunmanb merged commit 772b452 into Azure:master Sep 30, 2022
@lonegunmanb lonegunmanb deleted the limit-example-provider-version branch September 30, 2022 10:49
This was referenced Sep 30, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zioproto zioproto zioproto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lonegunmanb @zioproto