Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple example Jupyter notebook (for Binder) #127

Merged
merged 8 commits into from
Feb 22, 2021

Conversation

EricCousineau-TRI
Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI commented Jul 27, 2020

@EricCousineau-TRI EricCousineau-TRI marked this pull request as ready for review July 31, 2020 15:43
@thewtex thewtex requested review from iMichka and tao558 August 6, 2020 13:58
@tao558
Copy link
Contributor

tao558 commented Nov 10, 2020

Just as a note: this looks good so far. I'll do another review and approve when the todos are gone

@EricCousineau-TRI
Copy link
Contributor Author

Removed TODO about path stuff (I won't be able to investigate anytime soon).

Briefly trying the JupyterLab setup, but may descope that as well.

@EricCousineau-TRI
Copy link
Contributor Author

JupyterLab does not work easily; will leave in TODO; breadcrumb commit: 608f224

I think the remaining TODOs can remain as they are.

@tao558 Might you have time to take a look?

@tao558
Copy link
Contributor

tao558 commented Nov 19, 2020

@EricCousineau-TRI I'll take a look ASAP

setup.py Outdated Show resolved Hide resolved
.dockerignore Show resolved Hide resolved
.binder/README.md Outdated Show resolved Hide resolved
.binder/README.md Outdated Show resolved Hide resolved
.binder/README.md Outdated Show resolved Hide resolved
@EricCousineau-TRI
Copy link
Contributor Author

FYI I changed requirements away from use a set literal which is then converted to a list. That operation is redundant when dict/set become order-preserving (Python 3.5, I believe?), and provides information loss in lower Python versions.

Copy link
Contributor

@tao558 tao558 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the one comment looks good. Are you OK with me squashing the commits when merging?

.binder/README.md Show resolved Hide resolved
@EricCousineau-TRI
Copy link
Contributor Author

Are you OK with me squashing the commits when merging?

Yup!

.binder/README.md Outdated Show resolved Hide resolved
@EricCousineau-TRI
Copy link
Contributor Author

Please squash-merge if that's an option. If not, I can squash myself since review is done.

@tao558 tao558 merged commit aa5920c into CastXML:develop Feb 22, 2021
@tao558
Copy link
Contributor

tao558 commented Feb 22, 2021

Thanks @EricCousineau-TRI! Good to finally get this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants