-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some formatting in MPAS-Ocean Registry for generating docs #6293
Conversation
Discussion on this PR can be seen at: E3SM-Ocean-Discussion#81 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is all correct. Thanks!
components/mpas-ocean/bld/namelist_files/namelist_definition_mpaso.xml
Outdated
Show resolved
Hide resolved
@@ -1196,7 +1196,7 @@ Default: Defined in namelist_defaults.xml | |||
|
|||
<entry id="config_sw_absorption_type" type="char*1024" | |||
category="shortwaveRadiation" group="shortwaveRadiation"> | |||
Name of shortwave absorption type used in simulation. | |||
Name of shortwave absorption type used in simulation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may have to be fixed in Registry instead of by hand in this generated file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed this in the registry as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use an editor that automatically trims trailing whitespace (which I wish more folks would do). It seems easier to fix this than to revert it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to revert it if you fixed it in Registry as well. Thanks for taking that on
To generate Latex documentation from the Registry, we need to escape Latex in the namelist and variable descriptions.
69be54d
to
271b548
Compare
Fix some formatting in MPAS-Ocean Registry for generating docs To generate Latex documentation from the Registry, we need to escape Latex in the namelist and variable descriptions. [BFB]
@xylar -- thanks for having the bld files completely consistent with Registry. Passes sanity testing with:
merged to next |
merged to master |
@jonbob, thanks so much! |
This merge updates the E3SM-Project submodule from [93e511d](https://github.com/E3SM-Project/E3SM/tree/93e511d) to [31e0924](https://github.com/E3SM-Project/E3SM/tree/31e0924). This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list): - [ ] (ocn) E3SM-Project/E3SM#6256 - [ ] (ocn) E3SM-Project/E3SM#6224 - [ ] (ocn) E3SM-Project/E3SM#6270 - [ ] (ocn) E3SM-Project/E3SM#6293 - [ ] (ocn) E3SM-Project/E3SM#6321 - [ ] (ocn) E3SM-Project/E3SM#6262 - [ ] (ocn) E3SM-Project/E3SM#6300 - [ ] (ocn) E3SM-Project/E3SM#6334 - [ ] (ocn) E3SM-Project/E3SM#6371 - [ ] (ocn) E3SM-Project/E3SM#6288
To generate Latex documentation from the Registry, we need to escape Latex in the namelist and variable descriptions.