Add logic to catch issue when partition file assigns 0 cells to a pe #6321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Testing with a oQU240wLI configuration that pointed to a manipulated graph file both replicated the original issue and showed that this fix allows mpas-ocean to successfully complete |
|
@jonbob Thanks for fixing this. The logic makes sense to me. Would you like me to do any additional testing before approving? |
|
Thanks @cbegeman -- I don't think any testing is necessary, unless you would like to try it. I'm redoing the test I had setup just to make sure this solution works exactly as in the PR. And I'll do more testing to make sure it doesn't change answers on any regular E3SM tests before I merge it |
jonbob
added a commit
that referenced
this pull request
Apr 4, 2024
Add logic to catch issue when partition file assigns 0 cells to a pe When mpas-ocean runs with no cells assigned to a processor by a graph file and has landIcePressureOn, the run aborts. This fixes that situation by adding a check for the number of cells to the logic that causes the abort. Fixes: #6320 [BFB]
|
Passes:
merged to next |
xylar
added a commit
to xylar/compass
that referenced
this pull request
May 8, 2024
This merge updates the E3SM-Project submodule from [93e511d](https://github.com/E3SM-Project/E3SM/tree/93e511d) to [31e0924](https://github.com/E3SM-Project/E3SM/tree/31e0924). This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list): - [ ] (ocn) E3SM-Project/E3SM#6256 - [ ] (ocn) E3SM-Project/E3SM#6224 - [ ] (ocn) E3SM-Project/E3SM#6270 - [ ] (ocn) E3SM-Project/E3SM#6293 - [ ] (ocn) E3SM-Project/E3SM#6321 - [ ] (ocn) E3SM-Project/E3SM#6262 - [ ] (ocn) E3SM-Project/E3SM#6300 - [ ] (ocn) E3SM-Project/E3SM#6334 - [ ] (ocn) E3SM-Project/E3SM#6371 - [ ] (ocn) E3SM-Project/E3SM#6288
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When mpas-ocean runs with no cells assigned to a processor by a graph file and has landIcePressureOn, the run aborts. This fixes that situation by adding a check for the number of cells to the logic that causes the abort.
Fixes: #6320
[BFB]