-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch data ice-shelf melt rates to Paolo et al 2023 #6256
Switch data ice-shelf melt rates to Paolo et al 2023 #6256
Conversation
This PR is expected to be bit-for-bit for all current test configurations. It will be non-BFB for the DISMF test added in #6229 if that were to get merged before this PR. |
Testing@darincomeau ran a 5-year B-case with these changes. Analysis from that run are here: The results show the expected melt rates and melt fluxes, as discussed in MPAS-Dev/MPAS-Analysis#987. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on review and testing in E3SM-Ocean-Discussion#78 and MPAS-Dev/compass#778.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved based on testing.
It's the SMS_D_Ld1.ne30pg2_r05_IcoswISC30E3r5.CRYO1850-DISMF
test that will be non-BFB, added in #6221.
This data set is an Antarctic melt-rate climatology covering the years 1992-2017. The new datasets is an improvement because: * it is more accurate than the previous Adusumilli et al. (2020) * it includes rerouting of fluxes that are not under ice shelves in the MPAS-Ocean mesh * the fluxes are carefully renormalized so that the total flux is identical to the original Paolo et al. dataset * fixes the sign of the heat flux
e8c89df
to
8b58dcc
Compare
Simulation using new DISMF file is running here |
MPAS-Analysis results for a 10 year B-case are here: |
@xylar -- I don't think we expect this to be BFB for current tests with DISMF? |
@jonbob yes, I noted the test expected to be non-BFB above, so I guess we should change the BFB tag? |
Thanks @darincomeau -- I missed that! But I'll change the BFB flag and add something to the PR description |
…6256) Switch data ice-shelf melt rates to Paolo et al 2023 This data set is an Antarctic melt-rate climatology covering the years 1992-2017. The new datasets is an improvement because: * it is more accurate than the previous Adusumilli et al. (2020) * it includes rerouting of fluxes that are not under ice shelves in the MPAS-Ocean mesh * the fluxes are carefully renormalized so that the total flux is identical to the original Paolo et al. dataset * fixes the sign of the heat flux [non-BFB] only for current configurations with DISMF
Passes:
merged to next |
The only test this PR should impact is already failing on chrysalis, since it specifies debug:
This test also runs on pm-cpu and currently passes, so we'll expect it to have DIFFs |
merged to master and expected DIFFs blessed |
Thank you @jonbob! This is a really nice addition to have. Thanks @darincomeau and @cbegeman for your reviews and other help on this work! |
This merge updates the E3SM-Project submodule from [93e511d](https://github.com/E3SM-Project/E3SM/tree/93e511d) to [31e0924](https://github.com/E3SM-Project/E3SM/tree/31e0924). This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list): - [ ] (ocn) E3SM-Project/E3SM#6256 - [ ] (ocn) E3SM-Project/E3SM#6224 - [ ] (ocn) E3SM-Project/E3SM#6270 - [ ] (ocn) E3SM-Project/E3SM#6293 - [ ] (ocn) E3SM-Project/E3SM#6321 - [ ] (ocn) E3SM-Project/E3SM#6262 - [ ] (ocn) E3SM-Project/E3SM#6300 - [ ] (ocn) E3SM-Project/E3SM#6334 - [ ] (ocn) E3SM-Project/E3SM#6371 - [ ] (ocn) E3SM-Project/E3SM#6288
This data set is an Antarctic melt-rate climatology covering the years 1992-2017.
The new datasets is an improvement because:
E3SM-Ocean-Discussion#78 contains a small amount of relevant discussion. The new dataset was created in Compass following MPAS-Dev/compass#778.
[non-BFB] only for current configurations with DISMF