Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch data ice-shelf melt rates to Paolo et al 2023 #6256

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

xylar
Copy link
Contributor

@xylar xylar commented Feb 25, 2024

This data set is an Antarctic melt-rate climatology covering the years 1992-2017.

The new datasets is an improvement because:

  • it is more accurate than the previous Adusumilli et al. (2020)
  • it includes rerouting of fluxes that are not under ice shelves in the MPAS-Ocean mesh
  • the fluxes are carefully renormalized so that the total flux is identical to the original Paolo et al. dataset
  • fixes the sign of the heat flux (see Fix the sign of the heat flux for DISMF MPAS-Dev/compass#781)

E3SM-Ocean-Discussion#78 contains a small amount of relevant discussion. The new dataset was created in Compass following MPAS-Dev/compass#778.

[non-BFB] only for current configurations with DISMF

@xylar xylar added the BFB PR leaves answers BFB label Feb 25, 2024
@xylar
Copy link
Contributor Author

xylar commented Feb 25, 2024

This PR is expected to be bit-for-bit for all current test configurations. It will be non-BFB for the DISMF test added in #6229 if that were to get merged before this PR.

@xylar
Copy link
Contributor Author

xylar commented Feb 25, 2024

Testing

@darincomeau ran a 5-year B-case with these changes. Analysis from that run are here:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xylar/analysis/20240223.v3.LR.CRYO1850-DISMF.paolo.chrysalis/

The results show the expected melt rates and melt fluxes, as discussed in MPAS-Dev/MPAS-Analysis#987.

Copy link
Contributor

@cbegeman cbegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on review and testing in E3SM-Ocean-Discussion#78 and MPAS-Dev/compass#778.

Copy link
Member

@darincomeau darincomeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on testing.

It's the SMS_D_Ld1.ne30pg2_r05_IcoswISC30E3r5.CRYO1850-DISMF test that will be non-BFB, added in #6221.

This data set is an Antarctic melt-rate climatology covering the
years 1992-2017.

The new datasets is an improvement because:
* it is more accurate than the previous Adusumilli et al. (2020)
* it includes rerouting of fluxes that are not under ice shelves
  in the MPAS-Ocean mesh
* the fluxes are carefully renormalized so that the total flux is
  identical to the original Paolo et al. dataset
* fixes the sign of the heat flux
@xylar xylar force-pushed the ocn/update-icos30-dismf-to-paolo branch from e8c89df to 8b58dcc Compare February 27, 2024 20:35
@darincomeau
Copy link
Member

Simulation using new DISMF file is running here
/lcrc/group/acme/ac.dcomeau/E3SMv3/20240227.v3.LR.CRYO1850-DISMF.paolo.chrysalis

@xylar
Copy link
Contributor Author

xylar commented Feb 28, 2024

@jonbob
Copy link
Contributor

jonbob commented Mar 14, 2024

@xylar -- I don't think we expect this to be BFB for current tests with DISMF?

@darincomeau
Copy link
Member

@jonbob yes, I noted the test expected to be non-BFB above, so I guess we should change the BFB tag?

@jonbob
Copy link
Contributor

jonbob commented Mar 14, 2024

Thanks @darincomeau -- I missed that! But I'll change the BFB flag and add something to the PR description

@jonbob jonbob added non-BFB PR makes roundoff changes to answers. and removed BFB PR leaves answers BFB labels Mar 14, 2024
jonbob added a commit that referenced this pull request Mar 14, 2024
…6256)

Switch data ice-shelf melt rates to Paolo et al 2023

This data set is an Antarctic melt-rate climatology covering the years
1992-2017.

The new datasets is an improvement because:
* it is more accurate than the previous Adusumilli et al. (2020)
* it includes rerouting of fluxes that are not under ice shelves in the
  MPAS-Ocean mesh
* the fluxes are carefully renormalized so that the total flux is
  identical to the original Paolo et al. dataset
* fixes the sign of the heat flux

[non-BFB] only for current configurations with DISMF
@jonbob
Copy link
Contributor

jonbob commented Mar 14, 2024

Passes:

  • SMS_Ld1.T62_oQU240wLI.GMPAS-IAF-DISMF.chrysalis_intel (dataset not changed for this resolution)
  • ERS_Ld5.T62_oQU120.CMPASO-NYF.chrysalis_intel

merged to next

@jonbob
Copy link
Contributor

jonbob commented Mar 14, 2024

The only test this PR should impact is already failing on chrysalis, since it specifies debug:

SMS_D_Ld1.ne30pg2_r05_IcoswISC30E3r5.CRYO1850-DISMF.chrysalis_intel

This test also runs on pm-cpu and currently passes, so we'll expect it to have DIFFs

@jonbob jonbob merged commit f5f808f into E3SM-Project:master Mar 18, 2024
10 checks passed
@jonbob
Copy link
Contributor

jonbob commented Mar 18, 2024

merged to master and expected DIFFs blessed

@xylar xylar deleted the ocn/update-icos30-dismf-to-paolo branch March 19, 2024 07:21
@xylar
Copy link
Contributor Author

xylar commented Mar 19, 2024

Thank you @jonbob! This is a really nice addition to have.

Thanks @darincomeau and @cbegeman for your reviews and other help on this work!

xylar added a commit to xylar/compass that referenced this pull request May 8, 2024
This merge updates the E3SM-Project submodule from [93e511d](https://github.com/E3SM-Project/E3SM/tree/93e511d) to [31e0924](https://github.com/E3SM-Project/E3SM/tree/31e0924).

This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list):
- [ ]  (ocn) E3SM-Project/E3SM#6256
- [ ]  (ocn) E3SM-Project/E3SM#6224
- [ ]  (ocn) E3SM-Project/E3SM#6270
- [ ]  (ocn) E3SM-Project/E3SM#6293
- [ ]  (ocn) E3SM-Project/E3SM#6321
- [ ]  (ocn) E3SM-Project/E3SM#6262
- [ ]  (ocn) E3SM-Project/E3SM#6300
- [ ]  (ocn) E3SM-Project/E3SM#6334
- [ ]  (ocn) E3SM-Project/E3SM#6371
- [ ]  (ocn) E3SM-Project/E3SM#6288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mpas-ocean non-BFB PR makes roundoff changes to answers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants