Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.1-beta2 への機能取り込み #5002

Merged
merged 28 commits into from
Apr 12, 2021

Conversation

okazy
Copy link
Contributor

@okazy okazy commented Apr 5, 2021

概要(Overview・Refs Issue)

#4901 (comment) の ④ となります。

EC-CUBE 4.1-beta2 への機能追加として #4901 (comment) のコメントに従い以下を取り込んでいます。

方針(Policy)

実装に関する補足(Appendix)

Symfony 4.4 対応済み

テスト(Test)

それぞれの機能ごとに自動テストが通ることを確認しています。

相談(Discussion)

レビュワー確認項目

  • 動作確認
  • コードレビュー
  • E2E/Unit テスト確認(テストの追加・変更が必要かどうか)
  • 互換性が保持されているか
  • セキュリティ上の問題がないか

izayoi256 and others added 27 commits March 16, 2021 12:36
- Pageの検索条件の修正
- URLパラメータありのPageを除外
- コード整理
管理画面 商品のタグでの絞り込み
@codecov-io
Copy link

Codecov Report

Merging #5002 (ef3463d) into 4.1-beta2 (4574bdd) will decrease coverage by 0.19%.
The diff coverage is 23.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##             4.1-beta2    #5002      +/-   ##
===============================================
- Coverage        76.17%   75.97%   -0.20%     
- Complexity        5922     5946      +24     
===============================================
  Files              446      449       +3     
  Lines            20831    20918      +87     
===============================================
+ Hits             15867    15893      +26     
- Misses            4964     5025      +61     
Flag Coverage Δ Complexity Δ
tests 75.97% <23.00%> (-0.20%) 0.00 <29.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...Controller/Admin/Content/MaintenanceController.php 0.00% <0.00%> (ø) 8.00 <0.00> (ø)
src/Eccube/Controller/SitemapController.php 0.00% <0.00%> (ø) 7.00 <7.00> (?)
src/Eccube/Service/SystemService.php 30.30% <0.00%> (-4.32%) 28.00 <12.00> (+6.00) ⬇️
...Http/Authentication/EccubeLogoutSuccessHandler.php 37.50% <37.50%> (ø) 3.00 <3.00> (?)
src/Eccube/EventListener/MaintenanceListener.php 62.50% <62.50%> (ø) 6.00 <6.00> (?)
...rc/Eccube/EventListener/TwigInitializeListener.php 85.88% <100.00%> (+0.34%) 28.00 <0.00> (ø)
src/Eccube/Form/Type/Admin/SearchProductType.php 100.00% <100.00%> (ø) 4.00 <1.00> (ø)
src/Eccube/Repository/ProductRepository.php 96.96% <100.00%> (+0.07%) 56.00 <0.00> (+2.00)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4574bdd...ef3463d. Read the comment docs.

@okazy okazy added the improvement 機能改善 label Apr 6, 2021
@okazy okazy added this to the 4.1 milestone Apr 6, 2021
@okazy okazy marked this pull request as ready for review April 12, 2021 01:59
@okazy okazy changed the title [WIP] 4.1-beta2 への機能取り込み 4.1-beta2 への機能取り込み Apr 12, 2021
@okazy
Copy link
Contributor Author

okazy commented Apr 12, 2021

4.1-beta2 への機能取り込みの議論が終わりましたので Draft から ready に変えました。
以下も 4.1 への機能追加の対象ですが、プルリクがまだのため含めていません。
#4850

@chihiro-adachi chihiro-adachi merged commit 9b94ccf into EC-CUBE:4.1-beta2 Apr 12, 2021
@chihiro-adachi
Copy link
Contributor

@okazy マージしました。

@okazy
Copy link
Contributor Author

okazy commented Apr 12, 2021

ありがとうございます!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement 機能改善
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants