Fix regression for handling zero integer keys

They should be treated consistently with other integer-like keys. See [ruby-i18n#456] and [ruby-i18n#457] for reference. [ruby-i18n#456]: ruby-i18n#456 [ruby-i18n#457]: ruby-i18n#457
Envek · Feb 26, 2019 · e85bbb3 · e85bbb3
1 parent 70daba7
commit e85bbb3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/i18n.rb b/lib/i18n.rb
@@ -371,7 +371,7 @@ def normalize_key(key, separator)
           keys.delete('')
           keys.map! do |k|
             case k
-            when /\A[-+]?[1-9]\d*\z/ # integer
+            when /\A(?:0|[-+]?[1-9]\d*)\z/ # integer
               k.to_i
             when 'true'
               true

diff --git a/test/backend/simple_test.rb b/test/backend/simple_test.rb
@@ -19,9 +19,13 @@ def setup
   end
 
   test "simple backend translate: given integer as a key" do
-    store_translations :en, available: { 1 => "Yes", 2 => "No" }
+    store_translations :en, available: { 0 => "Dunno", 1 => "Yes", 2 => "No" }
+    assert_equal "Dunno", I18n.t(:available)[0]
+    assert_equal "Dunno", I18n.t('available.0')
     assert_equal "Yes", I18n.t(:available)[1]
     assert_equal "Yes", I18n.t('available.1')
+    assert_equal "No", I18n.t(:available)[2]
+    assert_equal "No", I18n.t('available.2')
   end
 
   test 'simple backend translate: given integer with a lead zero as a key' do