Fix regression with leading zero keys #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is one failing test on jruby |
|
Thank you for taking the time to fix this issue! |
|
I am not sure why that JRuby test is failing. I don't particularly care about it, since it's only failing in some of the JRuby tests. I have opened #459 to track this separate failure. |
|
@radar, thank you for merging this fix and new version release! 👍 |
Envek
added a commit
to Envek/i18n
that referenced
this pull request
Feb 26, 2019
They should be treated consistently with other integer-like keys. See [ruby-i18n#456] and [ruby-i18n#457] for reference. [ruby-i18n#456]: ruby-i18n#456 [ruby-i18n#457]: ruby-i18n#457
This was referenced Dec 16, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #456 (#456).