Fix single playlist view item index style #4179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PikachuEXE
requested review from
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
kommunarr
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Oct 18, 2023
ChunkyProgrammer
approved these changes
Oct 18, 2023
|
How well does hardcoding the width work with 4 digit number for example? |
|
We can handle this when and if there are people actually reporting issues for 4 digit number... |
|
@absidue seems to handle it pretty good VirtualBoxVM_CLTHc1FPin.mp4 |
absidue
approved these changes
Oct 20, 2023
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Oct 21, 2023
* development: Bump stefanzweifel/git-auto-commit-action from 4 to 5 (FreeTubeApp#4124) Upgrade electron from 22.x to 27.x and replace deprecated `protocol.registerBufferProtocol` (FreeTubeApp#3967) ! Fix single playlist view item index style (FreeTubeApp#4179) Fix proxy settings test (FreeTubeApp#4192) Translated using Weblate (German) fix typos in src/main/index.js comments (FreeTubeApp#4180) Translated using Weblate (English (United Kingdom)) Translated using Weblate (Indonesian) Translated using Weblate (Italian) Remove be.yaml file (FreeTubeApp#4176)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
N/A
Description
Single playlist view - item index got different width when number of digits changed
This make it have constant width (style from watch view playlist component)
Not sure if we should keep the gap (must consider the style when watched)
Screenshots
Before
After
Testing
Desktop
Additional context
Issue reported in PikachuEXE#49 (comment)