Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proxy settings test #4192

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

absidue
Copy link
Member

@absidue absidue commented Oct 19, 2023

Fix proxy settings test

Pull Request Type

  • Bugfix

Related issue

closes #4108

Description

The API we are using for the proxy test changed, now if you don't specifiy an IP or the output format, it redirects you to the docs page. This pull request adds the query parameter to set the output to JSON to make the test work again. (yes i also did some other small fixes)

Testing

  1. Download the tor expert bundle (https://www.torproject.org/download/tor/)
  2. Run the tor executable e.g. in windows tor.exe | more
  3. Enable the proxy in FreeTube and set it to socks 5
  4. Click test
  5. It should show a different IP and location than your current one.

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 0.19.1

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 19, 2023
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 19, 2023 21:53
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For MacOS I use brew install tor
image

@FreeTubeBot FreeTubeBot merged commit 046462e into FreeTubeApp:development Oct 20, 2023
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 20, 2023
@absidue absidue deleted the fix-proxy-test branch October 20, 2023 15:49
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Oct 21, 2023
* development:
  Bump stefanzweifel/git-auto-commit-action from 4 to 5 (FreeTubeApp#4124)
  Upgrade electron from 22.x to 27.x and replace deprecated `protocol.registerBufferProtocol` (FreeTubeApp#3967)
  ! Fix single playlist view item index style (FreeTubeApp#4179)
  Fix proxy settings test (FreeTubeApp#4192)
  Translated using Weblate (German)
  fix typos in src/main/index.js comments (FreeTubeApp#4180)
  Translated using Weblate (English (United Kingdom))
  Translated using Weblate (Indonesian)
  Translated using Weblate (Italian)
  Remove be.yaml file (FreeTubeApp#4176)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Proxy settings not working with tor
5 participants