Adds open and close sounds for safes. #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to add the credit file, put yourself as the author, chose a license for the sound, CC0 or CC BY, and just put "recorded myself" or something similar for the link entry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple little PR to get my feet wet with working with soundpacks, adding two sound effects and their associated JSON for opening and closing safes, covering both regular and gun safes. I wasn’t sure what, if anything, I should place in the credits file considering I recorded and edited these sounds myself, so I left such a file out.
In addition, as I’m visually impaired and can’t touch the graphics version of the game and, thus, can’t lay hands on a copy of the game with support for soundpacks, these changes haven’t been tested. If the documentation is true and my brain hasn't sluffed away, it should, I hope, work.