Tube-Fed shotgun Reload Sounds #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds 4 reload sound effects for tube-magazine shotguns and the associated JSON for them, covering all shotguns save for break-action, magazine-fed, and rotary guns. All the sounds were recorded by myself with a Browning Auto 5 and empty shells, and, as is the case with #82, I have abstained from adding an attributions file considering I made them inhouse.
In addition, similarly to #82, these sounds have also not been tested in the game for the same reasons outlined there, namely that no soundpack-capable version of the game is accessible to blind users.