Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds reload sound effects for small-caliber handguns #85

Merged
merged 4 commits into from
Dec 21, 2023

Conversation

DoctorBoomstick
Copy link
Contributor

@DoctorBoomstick DoctorBoomstick commented Dec 19, 2023

This PR adds four sound effects, as well as their associated JSON, to cover reloads for .22 Long rifle, .32 ACP, and .380 ACP-calibre pistols. The Makarov and Kel-tech PF9 have also been included, as they’re fairly small enough to fall into the category of pocket handguns. All sounds were made in-house courtesy of an over-70-year-old Beretta M1934, one beaten magazine, and a few equally beaten snap-caps, and, while not identical to the manual of arms that would be used with each pistol covered here, I feel that it’s representative enough considering that we don’t track different sounds for if the player’s doing a tactical reload or loading in a fresh magazine.

As with #82 and #83, these sounds haven’t been tested in the game as I am blind, and the sound-pack capable builds of the game aren’t usable for blind users.

@DoctorBoomstick
Copy link
Contributor Author

@Fris0uman, thanks for pointing out the issue with the file paths. Sorry to ask, but I got a comment on the dev discord to the effect that the sounds are very sharp and could do with further tweaking. I personally don’t think that they’re too on the nose, and I, myself, quite like how sharp they are, though if you agree that they’re too keen, I’ll pass them through some filtering and EQ tweeks.

@Fris0uman
Copy link
Owner

2,3 and 4 are maybe a bit loud, and 1 would be enough. But let me test how it feels in game

@Fris0uman
Copy link
Owner

I lowered the volume a bit through json, and I think it's good now

@DoctorBoomstick
Copy link
Contributor Author

I lowered the volume a bit through json, and I think it's good now

   Thanks for testing them out and tweeking the volumes through JSON; sorry that I couldn’t do that part myself.

@Fris0uman Fris0uman merged commit 96141b9 into Fris0uman:main Dec 21, 2023
5 checks passed
@DoctorBoomstick DoctorBoomstick deleted the pocket_pistol branch January 12, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants