Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datastream_stream resource to include kms fields #7126

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

roaks3
Copy link
Contributor

@roaks3 roaks3 commented Jan 13, 2023

b/233804820
Relates to hashicorp/terraform-provider-google#10810

The datastream_stream resource was initially implemented here, and the kms-related fields were meant to be added in a follow-up. This PR contains those kms fields:

  • customer_managed_encryption_key
  • destination_config.bigquery_destination_config.source_hierarchy_datasets.dataset_template.kms_key_name

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

datastream: add `customer_managed_encryption_key` and `destination_config.bigquery_destination_config.source_hierarchy_datasets.dataset_template.kms_key_name` fields to `datastream_stream` resource

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 359 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 359 insertions(+), 1 deletion(-))
TF Validator: Diff ( 3 files changed, 24 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 5 files changed, 226 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2418
Passed tests 2165
Skipped tests: 250
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccDatastreamStream_datastreamStreamBigqueryExample|TestAccDatastreamStream_datastreamStreamFullExample|TestAccComputeForwardingRule_update

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccDatastreamStream_datastreamStreamBigqueryExample[Debug log]
TestAccDatastreamStream_datastreamStreamFullExample[Debug log]
TestAccComputeForwardingRule_update[Debug log]

All tests passed
View the build log or the debug log for each test

@roaks3
Copy link
Contributor Author

roaks3 commented Jan 13, 2023

Note that I originally submitted this change without the skip_vcr flags so that we could see the tests pass, but just added those flags back in.

@roaks3 roaks3 requested review from a team and slevenick and removed request for a team January 13, 2023 20:39
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 360 insertions(+))
Terraform Beta: Diff ( 3 files changed, 360 insertions(+))
TF Validator: Diff ( 3 files changed, 24 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 5 files changed, 226 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2419
Passed tests 2165
Skipped tests: 252
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccRegionInstanceGroupManager_stateful|TestAccComputeForwardingRule_update

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccComputeForwardingRule_update[Debug log]

Tests failed during RECORDING mode:
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants