Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datastream_stream resource to include kms fields #5120

Conversation

modular-magician
Copy link
Collaborator

b/233804820
Relates to hashicorp/terraform-provider-google#10810

The datastream_stream resource was initially implemented here, and the kms-related fields were meant to be added in a follow-up. This PR contains those kms fields:

  • customer_managed_encryption_key
  • destination_config.bigquery_destination_config.source_hierarchy_datasets.dataset_template.kms_key_name

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

datastream: add `customer_managed_encryption_key` and `destination_config.bigquery_destination_config.source_hierarchy_datasets.dataset_template.kms_key_name` fields to `datastream_stream` resource

Derived from GoogleCloudPlatform/magic-modules#7126

* Update datastream_stream resource to include kms fields

* Add skip_vcr back

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 845a2a8 into hashicorp:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant