Datastream Stream resource #13385
Merged
Datastream Stream resource #13385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added initial datastream Stream structure * Added basic test for datastream * Removed oracle support since it's hard to test * Added some additional fields that could not previously be handled * Added full example for datastream stream with MySQL -> GCS * Removed additional references to oracle on datastream stream * cleaned up api.yaml and terraform.yaml * Revert "Removed additional references to oracle on datastream stream" This reverts commit 6ce0d705e309f79f8372e9f9706c9c21d34a1415. * Revert "Removed oracle support since it's hard to test" This reverts commit 732cf3036db07192046cda17c85fcec3247b8588. * Added oracleSourceConfig.dropLargeObjects and oracleSourceConfig.streamLargeObjects * Require a value inside jsonFileFormat * Require a value inside bigqueryDestinationConfig * Corrected type of fileRotationMb * Added state field and added default_from_api to a few fields * Fixed typo * Corrected name of default_value property * Removed support for oracle and postgres from Datastream Stream This simplifies the PR; also they are not automatically testable * Converted status field to be computed We will likely want to use either default_from_api or use a desired_state field because this field is only partially specified * Added desired_state field * removed input: true from stream * ignore read on stream connection profiles * Added update test * Added unit test for customizediff * Added unit tests for customize diff * Added external providers * gofmt * Corrected deletion_protection usage * Updates due to code review * Cleaned up test issues * Corrections to tests * Fixed test issues * Added gcs file format to fix tests * Added projectNumberDiffSuppress * Added default_from_api for fileRotationMb * Corrected labels usage in tests * Corrected stream update verb * Cleaned up references to google_storage_bucket.bucket.name * Source / destination profile are not updatable * Marked column length fields as output-only * Made update test use checks instead of importstateverify for state / desired_state * gofmt * Add state to update mask if desired_state is changed Signed-off-by: Modular Magician <[email protected]>
Merged
5 tasks
This was referenced Jan 23, 2023
Merged
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of datastream stream resource. Resolved #10810
This does not cover all the fields in this very large resource. In particular I'm excluding CMEK fields and oracle & postgres (because those require specific handwritten tests) and oracle & postgres support (because that requires separate, non-automated testing.)
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#6806